Re: [9] Review Request: 8157320 The CheckboxMenuItem can not be selected

2016-05-30 Thread Ambarish Rapte
Hi Sergey, The fix looks good to me. Thanks for taking care of this 6191390-regression. Regards, Ambarish -Original Message- From: Sergey Bylokhov Sent: Wednesday, May 25, 2016 2:13 AM To: awt-dev@openjdk.java.net; Ambarish Rapte Subject: [9] Review Request: 8157320 The

Re: [9] Review request for 8022810: Cannot list all the available display modes on Ubuntu linux in case of two screen devices

2016-05-30 Thread Semyon Sadetsky
On 5/30/2016 8:35 PM, Sergey Bylokhov wrote: On 30.05.16 20:24, Semyon Sadetsky wrote: Will all these new display modes be accepted by the GraphicsDevice.setDisplayMode(dm)? Also please confirm that the new modes include the mode returned from GraphicsDevice.getDisplayMode(). The bug was file

[8] Review request for JDK-8158178: java.awt.SplashScreen.getSize() returns incorrect size for high dpi splash screens

2016-05-30 Thread Robin Stevens
Hello, please review the patch for JDK-8158178 ( https://bugs.openjdk.java.net/browse/JDK-8158178): http://cr.openjdk.java.net/~alexsch/robin.stevens/8158178/jdk8/webrev.00/ Thanks, Robin

[9] Review request for JDK-8158178 java.awt.SplashScreen.getSize() returns incorrect size for high dpi splash screens

2016-05-30 Thread Robin Stevens
Hello, Please review the update to the MultiResolutionSplashTest http://cr.openjdk.java.net/~alexsch/robin.stevens/8158178/webrev.00/ which is a test for JDK-8158178 ( https://bugs.openjdk.java.net/browse/JDK-8158178) Thanks, Robin

Re: [PATCH] 8043869 [macosx] java -splash does not honor @2x hi dpi notation for retina support

2016-05-30 Thread Alexandr Scherbatiy
On 5/30/2016 9:55 PM, Sergey Bylokhov wrote: On 30.05.16 21:48, Alexandr Scherbatiy wrote: But the patch for the test definitely also can be contributed. I have loaded it to: http://cr.openjdk.java.net/~alexsch/robin.stevens/8158178/webrev.00 What about jdk8? It seems it is affected also.

Re: [PATCH] 8043869 [macosx] java -splash does not honor @2x hi dpi notation for retina support

2016-05-30 Thread Sergey Bylokhov
On 30.05.16 21:48, Alexandr Scherbatiy wrote: But the patch for the test definitely also can be contributed. I have loaded it to: http://cr.openjdk.java.net/~alexsch/robin.stevens/8158178/webrev.00 What about jdk8? It seems it is affected also. Could you resend the review request with

Re: [PATCH] 8043869 [macosx] java -splash does not honor @2x hi dpi notation for retina support

2016-05-30 Thread Alexandr Scherbatiy
Hello Robin, Your bug report has been recorded under id: JDK-8158178 java.awt.SplashScreen.getSize() returns incorrect size for high dpi splash screens https://bugs.openjdk.java.net/browse/JDK-8158178 Thank you for the contribution. The described issue has been fixed in JDK 9

Re: [9] Review request for 8022810: Cannot list all the available display modes on Ubuntu linux in case of two screen devices

2016-05-30 Thread Sergey Bylokhov
On 30.05.16 20:24, Semyon Sadetsky wrote: Will all these new display modes be accepted by the GraphicsDevice.setDisplayMode(dm)? Also please confirm that the new modes include the mode returned from GraphicsDevice.getDisplayMode(). The bug was filed against the getDisplayModes(). The setDisplayM

Re: [9] Review request for 8075516: Deleting a file from either the open or save java.awt.FileDialog hangs.

2016-05-30 Thread Sergey Bylokhov
The fix looks fine, a few notes about the test: - Should the Frame be disposed like FileDialog? - Probably it will be possible to simplify the test for the tester, and create the folder and files from the test itself and to point the FileDialog to this folder? One of them should be removed and

Re: [9] Review request for 8022810: Cannot list all the available display modes on Ubuntu linux in case of two screen devices

2016-05-30 Thread Semyon Sadetsky
On 5/30/2016 8:07 PM, Sergey Bylokhov wrote: Hi, Semyon. Will all these new display modes be accepted by the GraphicsDevice.setDisplayMode(dm)? Also please confirm that the new modes include the mode returned from GraphicsDevice.getDisplayMode(). The bug was filed against the getDisplayModes(

Re: [9] Review request for 8022810: Cannot list all the available display modes on Ubuntu linux in case of two screen devices

2016-05-30 Thread Sergey Bylokhov
Hi, Semyon. Will all these new display modes be accepted by the GraphicsDevice.setDisplayMode(dm)? Also please confirm that the new modes include the mode returned from GraphicsDevice.getDisplayMode(). On 27.05.16 14:25, Alexandr Scherbatiy wrote: On 5/13/2016 9:53 AM, Semyon Sadetsky wrote:

[PATCH] 8043869 [macosx] java -splash does not honor @2x hi dpi notation for retina support

2016-05-30 Thread Robin Stevens
Hello, the patch for JDK-8043869 (introduced with change http://cr.openjdk.java.net/~alexsch/8043869/webrev.03/) contains a bug. The java.awt.SplashScreen#getSize returns an incorrect height value when a hi dpi splash screen is shown. There is no bug available yet in the public JIRA bug tracker, a

[9] Review Request: 8004693 TEST_BUG: java/awt/KeyboardFocusmanager/DefaultPolicyChange/DefaultPolicyChange_Swing.java fails

2016-05-30 Thread Sergey Bylokhov
Hello. Please review the fix for jdk9. The test DefaultPolicyChange_Swing.java has two issues: - It uses invokeLater(), so the test usually pass before the code is executed on the EDT, because the main thread completes before. - The test fetches the FocusTraversalPolicy from the current Keybo

Re: Taking screenshots on x11 composite desktop produce wrong result

2016-05-30 Thread Semyon Sadetsky
On 5/30/2016 1:02 PM, Mario Torre wrote: 2016-04-06 14:02 GMT+02:00 Semyon Sadetsky : On 4/6/2016 2:19 PM, Mario Torre wrote: On Wed, Apr 6, 2016 at 12:50 PM, Semyon Sadetsky wrote: Hello Mario, Seems X11 call would be the best solution for AWT Robot screenshots under Linux. I'm ready to

Re: [8u] Review request for 8157838 Personalized Windows Font Size is not taken into account in Java8u102

2016-05-30 Thread Alexandr Scherbatiy
On 5/28/2016 2:20 AM, Phil Race wrote: -Phil. On May 27, 2016, at 2:37 PM, Alexandr Scherbatiy wrote: On 5/28/2016 12:23 AM, Alexandr Scherbatiy wrote: The following article claims that DPI virtualization of not DPI–aware applications is available from Windows Vista: https://msdn.microsoft

Re: 回复: An issue of OpenJRE

2016-05-30 Thread Alexey Ivanov
Hi Rong, OpenJDK comes without font files in its jre/lib. Does OpenJDK not work as expected? By placing font files into jre/lib/fonts you change the behavior of the JRE, and you get unexpected results. Just don't copy font files into JRE directory. If you want to use additional fonts, instal

Re: Taking screenshots on x11 composite desktop produce wrong result

2016-05-30 Thread Mario Torre
2016-04-06 14:02 GMT+02:00 Semyon Sadetsky : > > > On 4/6/2016 2:19 PM, Mario Torre wrote: >> >> On Wed, Apr 6, 2016 at 12:50 PM, Semyon Sadetsky >> wrote: >>> >>> Hello Mario, >>> >>> Seems X11 call would be the best solution for AWT Robot screenshots under >>> Linux. I'm ready to approve it as a

Re: [9] Review request for 8156121: "Fail forward" fails for GTK3 if no GTK2 available

2016-05-30 Thread Semyon Sadetsky
Please review the updated webrev: http://cr.openjdk.java.net/~ssadetsky/8156121/webrev.01/ --Semyon On 5/27/2016 7:30 PM, Phil Race wrote: 67 n_libs = sizeof(gtk_libs) / sizeof(GtkLib); 68 load_order = malloc(1 + n_libs * sizeof(GtkLib *)); 69 load_order[n_libs] = 0; I t