Re: [9] Review request for 8061637: GraphicsEnvironment API does not detect dynamically attached graphics device

I am not very familiar with this code, but why is this discussion centred around D3D? The GDI pipeline is just as "popular" on Windows due to Intel chipsets. -phil. On 05/23/2016 07:36 AM, Semyon Sadetsky wrote: On 5/23/2016 5:00 PM, Sergey Bylokhov wrote: On 23.05.16 13:29, Semyon

Re: Review request for JDK-8157476 -Wlogical-not-parentheses warnings in JRSUIConstantSync.m

Can I get somebody to look at this? Just point me in the right direction if I'm in the wrong place, please. —Dan > On May 20, 2016, at 1:52 PM, Dan Smith wrote: > > https://bugs.openjdk.java.net/browse/JDK-8157476 > > I noticed this code triggering a LOT of warnings

Re: [8u] Review request for 8157838 Personalized Windows Font Size is not taken into account in Java8u102

On 5/31/2016 6:35 PM, Sergey Bylokhov wrote: +1 to revert the fix which caused a regression. Should we create the new CR to refix it later or we will provide the fix in jdk9 only? The fix is provided to JDK 8u only. It is under discussion should the better fix be provided. Thanks,

Re: [9] Review request for 8022810: Cannot list all the available display modes on Ubuntu linux in case of two screen devices

On 31.05.16 18:49, Semyon Sadetsky wrote: Can you please provide the output of the test from the CR before/after the fix on your system? it is not necessary. You can run the provided test before and the fix and see that the list returned by getDisplayModes() is identical to xrandr output for

Re: [9] Review request for 8022810: Cannot list all the available display modes on Ubuntu linux in case of two screen devices

On 5/31/2016 6:22 PM, Sergey Bylokhov wrote: On 31.05.16 18:05, Semyon Sadetsky wrote: On 5/31/2016 5:18 PM, Sergey Bylokhov wrote: On 31.05.16 17:09, Semyon Sadetsky wrote: This is not true. Current mode is returned for screen > 0 Does it mean that this part in the description is

Re: [8u] Review request for 8157838 Personalized Windows Font Size is not taken into account in Java8u102

+1 to revert the fix which caused a regression. Should we create the new CR to refix it later or we will provide the fix in jdk9 only? On 31.05.16 16:52, Philip Race wrote: Hi, So it seems probable from these that being "dpiaware" means that all windows versions will behave the same for the

Re: [9] Review request for 8022810: Cannot list all the available display modes on Ubuntu linux in case of two screen devices

On 31.05.16 18:05, Semyon Sadetsky wrote: On 5/31/2016 5:18 PM, Sergey Bylokhov wrote: On 31.05.16 17:09, Semyon Sadetsky wrote: This is not true. Current mode is returned for screen > 0 Does it mean that this part in the description is incorrect? it depends on the OS and its

Re: Taking screenshots on x11 composite desktop produce wrong result

Looks fine to me. Thanks, Alexander. On 31/05/16 17:29, Sergey Bylokhov wrote: Hi, Mario. Thanks for your contribution! there is tiny typo in the native: isGtkSupported should be useGtk. It will be good if someone run jprt job to confirm that the build is ok, since make file was changed.

Re: [9] Review request for 8022810: Cannot list all the available display modes on Ubuntu linux in case of two screen devices

On 5/31/2016 5:18 PM, Sergey Bylokhov wrote: On 31.05.16 17:09, Semyon Sadetsky wrote: This is not true. Current mode is returned for screen > 0 Does it mean that this part in the description is incorrect? it depends on the OS and its configuration I guess. For Ubuntu 14/15 and OEL 6/7 it

Re: Review request for 6429675: getMaximumsize() size of the frame less than the minimumsize of Frame.

Hi, 2 questions: - Shouldn't the introduced side effect for setMaximum/MinimumSize() be described in JComponent's javadocs as well? - Doesn't it breaks the JavaBeans specs if the property is adjusted but the corresponding property change event is not sent? --Semyon On 4/29/2016 5:09

Re: [9] Review request for 8022810: Cannot list all the available display modes on Ubuntu linux in case of two screen devices

On 31.05.16 17:09, Semyon Sadetsky wrote: This is not true. Current mode is returned for screen > 0 Does it mean that this part in the description is incorrect? Compile and run it on a system with two displays. Here is output when both display are switched on

Re: [9] Review request for 8022810: Cannot list all the available display modes on Ubuntu linux in case of two screen devices

On 5/31/2016 4:53 PM, Sergey Bylokhov wrote: On 31.05.16 0:21, Semyon Sadetsky wrote: setDisplayMode() has been working if Xinerama is off. When Xinerama is on it could not set some modes for the screen 0 if there were incompatible modes from other screens in the list, and for all other

Re: [9] Review request for 8022810: Cannot list all the available display modes on Ubuntu linux in case of two screen devices

On 31.05.16 0:21, Semyon Sadetsky wrote: setDisplayMode() has been working if Xinerama is off. When Xinerama is on it could not set some modes for the screen 0 if there were incompatible modes from other screens in the list, and for all other screens there were no modes. I am talking about

Re: [8u] Review request for 8157838 Personalized Windows Font Size is not taken into account in Java8u102

Hi, So it seems probable from these that being "dpiaware" means that all windows versions will behave the same for the text size. What I don't know for sure but still suspect, is that non-dpi aware apps on Windows 8.1 and Win 10 will be the ones treated differently than they were on Win 7 &

Re: hg: jdk9/client/jdk: 8139218: Dialog that opens and closes quickly changes focus in original focusowner

I recall that we had a discussion that this fix version should be updated to take into account possibility of race of messages, when the focus was changed when we run SLoop and after exit we incorrectly clear it(we have to check timeout exit). Why it was pushed? On 31.05.16 15:57,

Re: [8] Review request for JDK-8158178: java.awt.SplashScreen.getSize() returns incorrect size for high dpi splash screens

Looks fine. On 31.05.16 13:56, Alexander Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 31/05/16 00:14, Robin Stevens wrote: Hello, please review the patch for JDK-8158178 (https://bugs.openjdk.java.net/browse/JDK-8158178):

Re: [9] Review request for 8075516: Deleting a file from either the open or save java.awt.FileDialog hangs.

Looks fine. On 31.05.16 10:15, Semyon Sadetsky wrote: Please review the updated webrev: http://cr.openjdk.java.net/~ssadetsky/8075516/webrev.01/ changes: several improvements for the manual test --Semyon On 5/30/2016 8:25 PM, Sergey Bylokhov wrote: The fix looks fine, a few notes about the

Re: [9] Review Request: 8157320 The CheckboxMenuItem can not be selected

The fix looks good to me. Thanks, Alexandr. On 25/05/16 00:43, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. The fix for JDK-6191390 [1] does not take into account that the action(final long when) method is overridden in the XCheckboxMenuItemPeer.java and after JDK-6191390

Re: [8] Review request for JDK-8158178: java.awt.SplashScreen.getSize() returns incorrect size for high dpi splash screens

The fix looks good to me. Thanks, Alexandr. On 31/05/16 00:14, Robin Stevens wrote: Hello, please review the patch for JDK-8158178 (https://bugs.openjdk.java.net/browse/JDK-8158178): http://cr.openjdk.java.net/~alexsch/robin.stevens/8158178/jdk8/webrev.00/

Re: [9] Review request for JDK-8158178 java.awt.SplashScreen.getSize() returns incorrect size for high dpi splash screens

The fix looks good to me. Thanks, Alexandr. On 31/05/16 00:13, Robin Stevens wrote: Hello, Please review the update to the MultiResolutionSplashTest http://cr.openjdk.java.net/~alexsch/robin.stevens/8158178/webrev.00/

Re: Taking screenshots on x11 composite desktop produce wrong result

On 5/31/2016 1:36 PM, Mario Torre wrote: 2016-05-30 17:53 GMT+02:00 Semyon Sadetsky : The rest is OK to me. Great, thanks! This is the final webrev: http://cr.openjdk.java.net/~neugens/8150954/webrev.04/ Thanks a lot! Assuming it's still OK for you, I

Re: Taking screenshots on x11 composite desktop produce wrong result

2016-05-30 17:53 GMT+02:00 Semyon Sadetsky : > The rest is OK to me. Great, thanks! This is the final webrev: http://cr.openjdk.java.net/~neugens/8150954/webrev.04/ Assuming it's still OK for you, I believe I need another reviewer's OK to push? Cheers, Mario --

Re: [9] Review request for 8075516: Deleting a file from either the open or save java.awt.FileDialog hangs.

Please review the updated webrev: http://cr.openjdk.java.net/~ssadetsky/8075516/webrev.01/ changes: several improvements for the manual test --Semyon On 5/30/2016 8:25 PM, Sergey Bylokhov wrote: The fix looks fine, a few notes about the test: - Should the Frame be disposed like FileDialog?

Re: [9] Review Request: 8157320 The CheckboxMenuItem can not be selected

Hi Sergey, The fix looks good to me. Thanks for taking care of this 6191390-regression. Regards, Ambarish -Original Message- From: Sergey Bylokhov Sent: Wednesday, May 25, 2016 2:13 AM To: awt-dev@openjdk.java.net; Ambarish Rapte Subject: [9] Review Request: 8157320 The