Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

Hello, Please review the new version of the fix for JDK9. 1. "forRemoval = true" is added to @Deprecated annotation for JSObject.getWindow(Applet) method. 2. A new doc bundle for JSObject documentation is added in the docs build. Webrev:

Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

That’s right. It requires to add a new doc bundle in the docs build. What you did was the right direction. Can you update the webrev? FYI. There is an effort under discussion to revisit the number of docs bundle generated and clean up the docs build. Mandy > On Jun 8, 2016, at 2:48 PM,

Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

NON_CORE_PKGS variable is not used in make/Javadoc.gmk, so just adding a new package in this variable will not make this package included in any docs. We will need to create a new javadoc target for JSObject documentation ( or add it to some existing target, but it doesn't look like there is

Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

Goo.d It should have forRemoval=true in @Deprecated then. Mandy > On Jun 8, 2016, at 1:13 PM, Kevin Rushforth > wrote: > > Yes, the plan is to deprecate it in 9 and remove it in a future release. > > -- Kevin > > > Mandy Chung wrote: >> The client team owns

Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

Sorry, we had LIVECONNECT_PKGS previously... -DrD- > How about NON_CORE_PKGS.gmk for javadoc? > > Something like: > > diff --git a/make/common/NON_CORE_PKGS.gmk b/make/common/NON_CORE_PKGS.gmk > --- a/make/common/NON_CORE_PKGS.gmk > +++ b/make/common/NON_CORE_PKGS.gmk > @@ -44,6 +44,8 @@ >

Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

How about NON_CORE_PKGS.gmk for javadoc? Something like: diff --git a/make/common/NON_CORE_PKGS.gmk b/make/common/NON_CORE_PKGS.gmk --- a/make/common/NON_CORE_PKGS.gmk +++ b/make/common/NON_CORE_PKGS.gmk @@ -44,6 +44,8 @@ org.w3c.dom.events \ org.w3c.dom.views +JSOBJECT_PKGS =

Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

Clarification: in a future *as of yet unspecified* release :) -DrD- > On Jun 8, 2016, at 1:13 PM, Kevin Rushforth > wrote: > > Yes, the plan is to deprecate it in 9 and remove it in a future release. > > -- Kevin > > > Mandy Chung wrote: >> The client team owns

Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

Yes, the plan is to deprecate it in 9 and remove it in a future release. -- Kevin Mandy Chung wrote: The client team owns jdk.jsobject module and so I add awt-dev to this thread. And bcc jdk9-dev. It is not Java SE API and it should not add to CORE-PKGS.gmk. As for @Deprecated, I believe

Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

The client team owns jdk.jsobject module and so I add awt-dev to this thread. And bcc jdk9-dev. It is not Java SE API and it should not add to CORE-PKGS.gmk. As for @Deprecated, I believe the plan is to remove the getWindows method in a future release. Kevin and Dave can confirm. Mandy >

Re: hg: jdk9/client/jdk: 8139218: Dialog that opens and closes quickly changes focus in original focusowner

Please clarify, or revert the fix, or file the new CR. On 31.05.16 16:31, Sergey Bylokhov wrote: I recall that we had a discussion that this fix version should be updated to take into account possibility of race of messages, when the focus was changed when we run SLoop and after exit we

Re: [9] Review Request: 8004693 TEST_BUG: java/awt/KeyboardFocusmanager/DefaultPolicyChange/DefaultPolicyChange_Swing.java fails

On 08.06.16 10:12, Semyon Sadetsky wrote: Since method equals() is not specified in the FTP class, you cannot make any assumption how it is implemented, it may return true for different classes instances. So in the test the policy untouchability should be checked by ==, without any additional

Re: [9] Review request for 8025130: [macosx] Frame setLocationByPlatform has no effect under Mac OS X

Hello Dmitry Looks good! Thanks alexp On 6/8/2016 12:16, dmitry markov wrote: Hi Semyon, Thank you for the review. I have updated the fix based on your suggestions. Just in case the updated webrev is located at http://cr.openjdk.java.net/~dmarkov/8025130/webrev.01/ Thanks, Dmitry On

Re: [9] Review request for 8025130: [macosx] Frame setLocationByPlatform has no effect under Mac OS X

Thank you Dmitry. You could change it upon the push. Still looks good to me. --Semyon On 6/8/2016 12:16 PM, dmitry markov wrote: Hi Semyon, Thank you for the review. I have updated the fix based on your suggestions. Just in case the updated webrev is located at

Re: [9] Review request for 8025130: [macosx] Frame setLocationByPlatform has no effect under Mac OS X

Hi Semyon, Thank you for the review. I have updated the fix based on your suggestions. Just in case the updated webrev is located at http://cr.openjdk.java.net/~dmarkov/8025130/webrev.01/ Thanks, Dmitry On 08/06/2016 10:44, Semyon Sadetsky wrote: Hi Dmitri, The fix looks good to me. In

Re: Review request for 8151385: [hidpi] JOptionPane-Icons only partially visible when using Windows 10 L

Hey Alexandr, > On Jun 7, 2016, at 17:44, Alexandr Scherbatiy > wrote: > > I slightly updated your fix to return a multi-resolution image with base icon > size when icon size is greater than the real icon size. This allows to draw a > high-resolution icon to

Re: [9] Review request for 8025130: [macosx] Frame setLocationByPlatform has no effect under Mac OS X

Hi Dmitri, The fix looks good to me. In the test please dispose frames in case of exception and don't forget to set the correct GPL year in AWTWindow.m. --Semyon On 6/8/2016 10:07 AM, dmitry markov wrote: Any volunteers to review the fix? Thanks in advance, Dmitry On 02/06/2016 11:18,

Re: [9] Review Request: 8004693 TEST_BUG: java/awt/KeyboardFocusmanager/DefaultPolicyChange/DefaultPolicyChange_Swing.java fails

On 6/7/2016 3:31 PM, Sergey Bylokhov wrote: On 07.06.16 12:31, Semyon Sadetsky wrote: I cannot agree with this assumption. Since the policy should not be touched for the existing components, the test should prove that the policy object instances are the same, other behavior is an error. The

Re: [9] Review request for 8025130: [macosx] Frame setLocationByPlatform has no effect under Mac OS X

Any volunteers to review the fix? Thanks in advance, Dmitry On 02/06/2016 11:18, dmitry markov wrote: Hello, Could you review a fix for jdk9, please? bug: https://bugs.openjdk.java.net/browse/JDK-8025130 webrev: http://cr.openjdk.java.net/~dmarkov/8025130/webrev.00/ Problem