Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

2016-06-09 Thread Kevin Rushforth
Looks fine to me. -- Kevin Daniil Titov wrote: Thank you, Mandy! The long line is corrected. Webrev: http://cr.openjdk.java.net/~dtitov/8156960/jdk/webrev.03 http://cr.openjdk.java.net/~dtitov/8156960/webrev.03 Bug: https://bugs.openjdk.java.net/browse/JDK-8156960 Best regards,

Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

2016-06-09 Thread Daniil Titov
Thank you, Mandy! The long line is corrected. Webrev: http://cr.openjdk.java.net/~dtitov/8156960/jdk/webrev.03 http://cr.openjdk.java.net/~dtitov/8156960/webrev.03 Bug: https://bugs.openjdk.java.net/browse/JDK-8156960 Best regards, Daniil -Original Message- From: Mandy

Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

2016-06-09 Thread Mandy Chung
> On Jun 9, 2016, at 9:08 AM, Daniil Titov wrote: > > Thank you, Erik! > > Please review the new version of the patch that has "../" fixed: > > Webrev: http://cr.openjdk.java.net/~dtitov/8156960/jdk/webrev.02 >

Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

2016-06-09 Thread Daniil Titov
Thank you, Erik! Please review the new version of the patch that has "../" fixed: Webrev: http://cr.openjdk.java.net/~dtitov/8156960/jdk/webrev.02 http://cr.openjdk.java.net/~dtitov/8156960/webrev.02/ Bug: https://bugs.openjdk.java.net/browse/JDK-8156960 Best regards, Daniil

Re: Review request for 8151385: [hidpi] JOptionPane-Icons only partially visible when using Windows 10 L

2016-06-09 Thread Sergey Bylokhov
+1 On 08.06.16 10:57, Hendrik Schreiber wrote: Hey Alexandr, On Jun 7, 2016, at 17:44, Alexandr Scherbatiy wrote: I slightly updated your fix to return a multi-resolution image with base icon size when icon size is greater than the real icon size. This

Re: [9] Review Request: 8004693 TEST_BUG: java/awt/KeyboardFocusmanager/DefaultPolicyChange/DefaultPolicyChange_Swing.java fails

2016-06-09 Thread Sergey Bylokhov
On 08.06.16 19:53, Semyon Sadetsky wrote: Yes, but the Object#equlas() does not prohibit different class instances to be equal. The purpose of the test is to prove that existing component's FTP instances remain untouchable during the default FTP change regardless of the specific FTP

Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

2016-06-09 Thread Erik Joelsson
Hello, Generally looks good, but I do think this needs to be changed: JSOBJECT_DOCDIR := $(JRE_API_DOCSDIR)/plugin/jsobject JSOBJECT2COREAPI := ../../../$(JDKJRE2COREAPI) The number of ../ should probably match the directory level depth of the variable before it, at least it looks that way