Re: [9] Review request for JDK-8155740: [macosx] robot.keyPress and robot.keyRelease do not generate key event for Alt-Graph key VK_ALT_GRAPH.

OK, Thanks. Looks good to me. --Semyon On 6/14/2016 9:48 PM, Manajit Halder wrote: Hi Semyon, Alignement is improved and it looks correct on Xcode and Netbeans. Please review the latest webrev: http://cr.openjdk.java.net/~mhalder/8155740/webrev.05/

Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

David DeHaven wrote: David had said, it seems safer to leave it false for now and revisit marking for removal in 10 I think this means, "set forRemoval=false in 9, set forRemoval=true in 10, and actually remove it in 11". I said that in reference to Applet, not JSObject.

Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

> David had said, > >> it seems safer to leave it false for now and revisit marking for removal in >> 10 > > I think this means, "set forRemoval=false in 9, set forRemoval=true in 10, > and actually remove it in 11". I said that in reference to Applet, not JSObject. I now think JSObject shou

Re: [9] Review request for JDK-8155740: [macosx] robot.keyPress and robot.keyRelease do not generate key event for Alt-Graph key VK_ALT_GRAPH.

Hi Semyon, Alignement is improved and it looks correct on Xcode and Netbeans. Please review the latest webrev: http://cr.openjdk.java.net/~mhalder/8155740/webrev.05/ Thanks, Manajit > On 14-Jun-2016, at 3:17 pm, Semyon Sadetsky > wrote

Re: [9] Review request for 8016313: java.awt.Headless exception has no spec since its creation

My reading of the original complaint about this is that the "extra" default message occurs only if the environment is considered to actually be headless. Your update to the specification does not seem to explicitly account for this. You need to add words along the lines of "The text of the def

[9] Review request for 8117886: There is no tooltip while moving the mouse on the tray icon.

Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8117886 webrev: http://cr.openjdk.java.net/~ssadetsky/8117886/webrev.00/ gnome3 DE got a new DE notifications bar, so the tooltips for tray icons have gone. Just note about that in the TrayIcon's javadoc. --Se

[9] Review request for 8016313: java.awt.Headless exception has no spec since its creation

Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8016313 webrev: http://cr.openjdk.java.net/~ssadetsky/8016313/webrev.00/ HeadlessException was poorly specified. The improved javadocs are added to the class. --Semyon

Re: [9] Review request for JDK-8155740: [macosx] robot.keyPress and robot.keyRelease do not generate key event for Alt-Graph key VK_ALT_GRAPH.

Hi Manajit, Could you improve the alignment of lines 272-286? --Semyon On 6/13/2016 2:29 PM, Manajit Halder wrote: Hi Semyon and Sergey, Code is modified as per the comment. Please review the modified webrev. http://cr.openjdk.java.net/~mhalder/8155740/webrev.04/

Re:

The fix looks good to me. Thanks, Alexandr. On 6/9/2016 12:43 PM, Sergey Bylokhov wrote: +1 On 08.06.16 10:57, Hendrik Schreiber wrote: Hey Alexandr, On Jun 7, 2016, at 17:44, Alexandr Scherbatiy wrote: I slightly updated your fix to return a multi-resolution image with base icon size