Re: Review Request: JDK-8158478 : X11 keysym XK_topt maps to the wrong Unicode character

Hi Prem, Looks good to me. Regards, Ambarish -Original Message- From: Sergey Bylokhov Sent: Thursday, June 30, 2016 4:56 PM To: Prem Balakrishnan; Semyon Sadetsky; Ambarish Rapte; awt-dev@openjdk.java.net Subject: Re: Review Request: JDK-8158478 : X11 keysym XK_topt maps to the w

Re: [9] Review request for JDK-8160650: Couple awt and swing tests have wrong require jtreg arguments

The fix looks good to me. Thanks, Alexandr. On 6/30/2016 4:01 PM, mikhail cherkasov wrote: Hi all, jbs: https://bugs.openjdk.java.net/browse/JDK-8160650 webrev:http://cr.openjdk.java.net/~mcherkas/8160650/9/webrev/ Couple awt and swing tests have wrong require jtreg arguments, the following t

Re: [9] Review request for JDK-8160650: Couple awt and swing tests have wrong require jtreg arguments

Looks fine. On 30.06.16 16:01, mikhail cherkasov wrote: Hi all, jbs: https://bugs.openjdk.java.net/browse/JDK-8160650 webrev:http://cr.openjdk.java.net/~mcherkas/8160650/9/webrev/ Couple awt and swing tests have wrong require jtreg arguments, the following tests should use "os.family" instead

Re: [9] Review request for 8061637: GraphicsEnvironment API does not detect dynamically attached graphics device

On 5/31/2016 10:12 PM, Phil Race wrote: I am not very familiar with this code, but why is this discussion centred around D3D? The GDI pipeline is just as "popular" on Windows due to Intel chipsets. Because we always use D3DGraphicsDevice if d3d is available. new D3DGraphicsDevice()-> getDeviceC

Re: [9] Review request for JDK-7156316: [macosx] Ctrl+Space does generate Unknown keychar

On 27/06/16 21:57, Manajit Halder wrote: Hi All, Kindly review the fix for JDK9. *Bug*: https://bugs.openjdk.java.net/browse/JDK-7156316 _ _ *Webrev*: http://cr.openjdk.java.net/~mhalder/7156316/webrev.00/ *Issue: * [macosx] Ctrl+Spa

Re: [9] Review request for 8160623: [PIT] Exception running java/awt/event/KeyEvent/KeyChar/KeyCharTest.java

Whilst I am not an expert on this code it looks OK but it seems like the failing regression test should be updated with this bug id as part of the change .. -phil. On 6/30/16, 7:38 AM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8160

Re: [9] Review request for 8160623: [PIT] Exception running java/awt/event/KeyEvent/KeyChar/KeyCharTest.java

Have it built and tested on a couple of locales: all seems working OK. Fine with me! -yan On 06/30/2016 05:38 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8160623 webrev: http://cr.openjdk.java.net/~ssadetsky/8160623/webrev.00/

[9] Review request for 8160623: [PIT] Exception running java/awt/event/KeyEvent/KeyChar/KeyCharTest.java

Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8160623 webrev: http://cr.openjdk.java.net/~ssadetsky/8160623/webrev.00/ This a regression from JDK-8139189. The wchar array may contain all zeroes for some known keys (likely for Delete key only) and it should

[9] Review request for JDK-8160650: Couple awt and swing tests have wrong require jtreg arguments

Hi all, jbs: https://bugs.openjdk.java.net/browse/JDK-8160650 webrev:http://cr.openjdk.java.net/~mcherkas/8160650/9/webrev/ Couple awt and swing tests have wrong require jtreg arguments, the following tests should use "os.family" instead of "os.name": javax/swing/LookAndFeel/8145547/DemandGTK.j

Re: Review Request: JDK-8158478 : X11 keysym XK_topt maps to the wrong Unicode character

looks fine On 16.06.16 8:58, Prem Balakrishnan wrote: Reminder *From:*Prem Balakrishnan *Sent:* Monday, June 06, 2016 3:50 PM *To:* Sergey Bylokhov; Semyon Sadetsky; Ambarish Rapte; awt-dev@openjdk.java.net *Subject:* Review Request: JDK-8158478 : X11 keysym XK_topt maps to the wrong Unicode

Re: Review request for 8143064 Icons are not properly rendered with Windows L&F on HiDPI display

Hi Alexander, I have added printout after the line 679 of the XPStyle.java: 676 ThemeReader.paintBackground(SunWritableRaster.stealData(dbi, 0), 677part.getControlName(c), part.getValue(), 678State.getValue(part, s