Re: [9] Review request for 8160623: [PIT] Exception running java/awt/event/KeyEvent/KeyChar/KeyCharTest.java

2016-07-01 Thread Alexandr Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 6/30/2016 5:38 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8160623 webrev: http://cr.openjdk.java.net/~ssadetsky/8160623/webrev.00/ This a regression from JDK-8139189. The wchar ar

Re: RFR(XS): 8160721: Avoid deoptimizations in Font.equals.

2016-07-01 Thread Phil Race
Please resend this to 2d-dev. All font related API and implementation is part of 2D, not AWT. -phil. On 7/1/2016 6:59 AM, Lindenmaier, Goetz wrote: Hi, This small fix improves performance of the C2 compiler. We see deoptimizations due to class casts in Font.equals. Use instanceof check inste

Re: RFR(XS): 8160721: Avoid deoptimizations in Font.equals.

2016-07-01 Thread Remi Forax
Hi Goetz, the test obj != null is not need, because null has no class. cheers, Rémi - Mail original - > De: "Goetz Lindenmaier" > À: awt-dev@openjdk.java.net > Envoyé: Vendredi 1 Juillet 2016 15:59:54 > Objet: RFR(XS): 8160721: Avoid deoptimizations in Font.equals. > Hi, > This s

RFR(XS): 8160721: Avoid deoptimizations in Font.equals.

2016-07-01 Thread Lindenmaier, Goetz
Hi, This small fix improves performance of the C2 compiler. We see deoptimizations due to class casts in Font.equals. Use instanceof check instead of catching the exception. Please review this change: http://cr.openjdk.java.net/~goetz/wr16/8160721-deoptFont/ Best regards, Goetz.