+1 .. although this needs a CCC too.
-phil.
On 6/15/16, 12:11 AM, Semyon Sadetsky wrote:
Thanks for review. Please look at the updated webrev:
http://cr.openjdk.java.net/~ssadetsky/8016313/webrev.01/
--Semyon
On 6/14/2016 8:44 PM, Phil Race wrote:
My reading of the original complaint about
I guess this is approved
-phil.
On 6/22/16, 2:40 AM, Semyon Sadetsky wrote:
Actually no missing file. Only the missed place to replace ordinal()
with getNumber().
--Semyon
On 5/27/2016 11:13 PM, Phil Race wrote:
So is there a missing file here or not ?
-phil.
On 05/26/2016 12:12 AM,
It is not always clear to me what warning is being suppressed and why you have
chosen a particular solution/action
this next one looks like it might introduce an unused variable warning.
What was it solving ? That the code was not checking a return value ?
size_t bytesWritten = write (
+1
--Semyon
On 05.07.2016 15:53, Alexandr Scherbatiy wrote:
The fix looks good to me.
Thanks,
Alexandr.
On 7/5/2016 2:24 PM, Manajit Halder wrote:
Hi Alexandr,
I feel it is not a problem to use "if (leftAltKeyPressed == YES)” and
"if (altGRPressed == NO)” as the variable
The fix looks good to me.
Thanks,
Alexandr.
On 7/5/2016 5:04 PM, Alexander Zvegintsev wrote:
Hello,
please review the fix
http://cr.openjdk.java.net/~azvegint/jdk/9/8155515/00
for the issue
https://bugs.openjdk.java.net/browse/JDK-8155515
Hello,
please review the fix
http://cr.openjdk.java.net/~azvegint/jdk/9/8159374/00
for the issue
https://bugs.openjdk.java.net/browse/JDK-8159374
--
--
Thanks,
Alexander.
Could you review the updated fix:
http://cr.openjdk.java.net/~alexsch/8143064/webrev.02
- the PainterMultiResolutionCachedImage.getWidth()/getHeight() methods
are overridden to not call the base resolution variant
- scale factors are added to the multi-resolution image
- component and args
