Re: [9] Fix for JDK-8074824: Resolve disabled warnings for libawt_xawt

On 07/07/2016 10:25 AM, Semyon Sadetsky wrote: On 7/7/2016 7:48 PM, Ajit Ghaisas wrote: Thanks Phil for the review. Please find my answers below. Semyon, can you please comment on Phil's question below? I agree with this change. The check is not needed. Ok. so the fix overall seems fine in

Re: [8] Review request JI-9041413: [macosx]"text/uri-list" dataflavor concats the first two strings

Thanks Alexander for creating the issue in the bug tracker and hosting the webrev. Do I need to send a new review request to the list with the official bug number in the subject, or is the current email thread sufficient ? Robin On Thu, Jul 7, 2016 at 9:36 AM, Alexandr Scherbatiy <

Re: Review request for 8143064 Icons are not properly rendered with Windows L on HiDPI display

Caching works. Icon sizes are correct as well. Why the check box image doesn't change its size with the scale? Only margins are growing. Is it expected behavior? --Semyon On 05.07.2016 16:53, Alexandr Scherbatiy wrote: Could you review the updated fix:

Re: [9] Fix for JDK-8074824: Resolve disabled warnings for libawt_xawt

On 7/7/2016 7:48 PM, Ajit Ghaisas wrote: Thanks Phil for the review. Please find my answers below. Semyon, can you please comment on Phil's question below? I agree with this change. The check is not needed. --Semyon Regards, Ajit -Original Message- From: Phil Race Sent: Wednesday,

Re: [9] Fix for JDK-8074824: Resolve disabled warnings for libawt_xawt

Thanks Phil for the review. Please find my answers below. Semyon, can you please comment on Phil's question below? Regards, Ajit -Original Message- From: Phil Race Sent: Wednesday, July 06, 2016 2:02 AM To: Ajit Ghaisas Cc: Sergey Bylokhov; Erik Joelsson; 2d-dev;

RFR(L): 8160974: [TESTBUG] Mark more headful tests with @key headful.

Hi, This change is 'L' because there are changes to a lot of files, but the changes are all similar, so it's rather easy to review. Similar to 8159690 I added @key headful to another around 600 tests. I used different patterns to grep for the headful exceptions. These are now all I could find

Re: Review Request For 8146230: Crash in JNI_ArgumentPusherVaArg::JNI_ArgumentPusherVaArg(_jmethodID*, __va_list_tag*)+0xa

On 07.07.2016 16:14, Ambarish Rapte wrote: Hi Semyon, 1. The _initIDs() functions are called from static initialization block of particular class, hence these functions would be called when class is getting loaded. The_initIDs() functions are used to initialize the IDs & get value

Re: Review Request For 8146230: Crash in JNI_ArgumentPusherVaArg::JNI_ArgumentPusherVaArg(_jmethodID*, __va_list_tag*)+0xa

Hi Semyon,       1. The _initIDs() functions are called from static initialization block of particular class, hence these functions would be called when class is getting loaded.      The _initIDs() functions are used to initialize the IDs & get value of Java class members only.  

Re: [9] Review request for JDK-8160266: [macosx] NestedModalDialogTest.java and NestedModelessDialogTest.java tests does not run with current JDK codebase after taking the files fro

Hi All, Gentle remainder. Please review the fix for issue https://bugs.openjdk.java.net/browse/JDK-8160266 . Thanks, Manajit > On 24-Jun-2016, at 8:53 pm, Manajit Halder wrote: > > Hi Sergey, > > Kindly review the

Re: [8] Review request JI-9041413: [macosx]"text/uri-list" dataflavor concats the first two strings

The issue is recorded under id JDK-8160941 "text/uri-list" dataflavor concats the first two strings https://bugs.openjdk.java.net/browse/JDK-8160941 The webrev is uploaded to http://cr.openjdk.java.net/~alexsch/robin.stevens/8160941/webrev.00 Thanks, Alexandr. On 7/7/2016

Re: RFR(XS): 8160721: Avoid deoptimizations in Font.equals.

Hi, can I consider this reviewed? Remi Forax and Phil Race had a look at this. Best regards, Goetz. > -Original Message- > From: Lindenmaier, Goetz > Sent: Montag, 4. Juli 2016 08:33 > To: 'Phil Race' ; awt-dev@openjdk.java.net; 2d-dev >

Re: [9] Review request for 8149115: [hidpi] Linux: display-wise scaling factor should probably be taken into account

The fix looks good to me. Thanks, Alexandr. On 7/6/2016 11:46 PM, Alexander Zvegintsev wrote: Still looks good. -- Thanks, Alexander. On 06.07.2016 21:42, Semyon Sadetsky wrote: Thanks, Alexander. Please see the updated webrev http://cr.openjdk.java.net/~ssadetsky/8149115/webrev.02/