Please review the fix for JDK-8160941 .
Webrev: http://cr.openjdk.java.net/~rstevens/8160941/webrev/
The problem: when copy-pasting (or drag-and-dropping) multiple files, the
data in the transferable for the flavor "text/uri-list" concats the first
two paths.
If you for example copy:
/Users/robi
Hi Ambarish,
Thank you for removing the lock.
But I still do not understand the root cause. waitForEvents() is only
called on the toolkit thread How it could be executed concurrently?
Are you able to reproduce the issue? Are you sure that correcting method
IDs initialization really fixes it
Hi Semyon,
Thanks for the review.
Please review the webrev.01, updated as per the review comments.
http://cr.openjdk.java.net/~arapte/8146230/webrev.01/
Changes:
Initializing the thread class references in
J
On 7/8/2016 2:28 PM, Alexandr Scherbatiy wrote:
On 7/7/2016 9:11 PM, Semyon Sadetsky wrote:
Caching works. Icon sizes are correct as well.
Why the check box image doesn't change its size with the scale? Only
margins are growing. Is it expected behavior?
Screenshot [1] shows checkboxes for t
Ping
It would be very nice if somebody could have a look at this webrev.
Thanks and kind regards, Oliver
>
> Oliver Bendig hat am 29. Juni 2016 um 15:54 geschrieben:
>
>
> Hi,
>
> here is a test for this. I updated the webrev.
> Webrev: http://cr.openjdk.java.net/~simo
On 7/7/2016 9:11 PM, Semyon Sadetsky wrote:
Caching works. Icon sizes are correct as well.
Why the check box image doesn't change its size with the scale? Only
margins are growing. Is it expected behavior?
Screenshot [1] shows checkboxes for the native control, java checkbox
with the fix and
Is it possible to get rid of the RobotUtilities class? Methods like
RobotUtilities.pressKey(int num)/releaseKey(int num) are just direct
calls to the corresponding methods in Robot.
Other necessary methods can be added to
test/java/awt/regtesthelpers/Util.java
Thanks,
Alexandr.
On 7/7/2016
+1
On 7/8/16 10:37 AM, Alexandr Scherbatiy wrote:
The fix looks good to me.
Thanks,
Alexandr.
On 7/8/2016 9:25 AM, Semyon Sadetsky wrote:
I have changed variables declaration style in systemScale.c, because
it produced warnings in Solaris build.
http://cr.openjdk.java.net/~ssadetsky/814911
On 7/4/2016 3:14 PM, Mario Torre wrote:
On Wed, Jun 29, 2016 at 12:40 PM, Mario Torre wrote:
Ping?
Ping Ping?
Just a question. The isGtkSupported is moved to be a local variable.
It seems its value can't be changed in the 'if' condition on the line 60.
Thanks,
Alexandr.
Cheers,
On 7/7/2016 10:07 PM, Robin Stevens wrote:
Thanks Alexander for creating the issue in the bug tracker and hosting
the webrev.
Do I need to send a new review request to the list with the official
bug number in the subject, or is the current email thread sufficient ?
Yes. You can just reply on
The fix looks good to me.
Thanks,
Alexandr.
On 7/8/2016 9:25 AM, Semyon Sadetsky wrote:
I have changed variables declaration style in systemScale.c, because
it produced warnings in Solaris build.
http://cr.openjdk.java.net/~ssadetsky/8149115/webrev.03/
--Semyon
On 7/7/2016 9:57 AM, Alexandr
11 matches
Mail list logo