Hello Mikhail,
good catch. I adjusted the code.
Webrev: http://cr.openjdk.java.net/~rstevens/8160941/webrev.01
Robin
On Mon, Jul 11, 2016 at 6:08 PM, Mikhail Cherkasov <
mikhail.cherka...@oracle.com> wrote:
> On 11.07.2016 18:55, Robin Stevens wrote:
>
>> However, that would cause an inconsis
+1
--Semyon
On 7/11/2016 8:10 PM, Alexandr Scherbatiy wrote:
The fix looks good to me.
Thanks,
Alexandr.
On 7/11/2016 6:02 PM, Mario Torre wrote:
On Fri, Jul 8, 2016 at 10:05 AM, Alexandr Scherbatiy
wrote:
On 7/4/2016 3:14 PM, Mario Torre wrote:
On Wed, Jun 29, 2016 at 12:40 PM, Mario Tor
On Mon, Jul 11, 2016 at 7:10 PM, Alexandr Scherbatiy
wrote:
> The fix looks good to me.
Great, I just updated my local repository, I'll push as soon as it's
done compiling.
Thanks!
Cheers,
Mario
The fix looks good to me.
Thanks,
Alexandr.
On 7/8/2016 3:09 PM, Oliver Bendig wrote:
Ping
It would be very nice if somebody could have a look at this webrev.
Thanks and kind regards, Oliver
Oliver Bendig hat am 29. Juni 2016 um 15:54
geschrieben:
Hi,
here is a test for this. I
The fix looks good to me.
Thanks,
Alexandr.
On 7/11/2016 6:02 PM, Mario Torre wrote:
On Fri, Jul 8, 2016 at 10:05 AM, Alexandr Scherbatiy
wrote:
On 7/4/2016 3:14 PM, Mario Torre wrote:
On Wed, Jun 29, 2016 at 12:40 PM, Mario Torre wrote:
Ping?
Ping Ping?
Just a question. The isGtkSup
On 11.07.2016 18:55, Robin Stevens wrote:
However, that would cause an inconsistency with other operating systems.
ok, but then let's simplify it:
remove this line:
sb.append(strings[0]);
and start cycle from 0:
for(int i = 0; i < strings.length; i++) {
sb.append(strings[i]);
sb.app
Hello Mikhail,
swapping the order of the statements in the loop was my first idea as well.
However, that would cause an inconsistency with other operating systems.
When I try with JDK8 on a Linux (Ubuntu) machine, I always get a string
with a line separator at the end:
Drag-and-drop a single file
On Fri, Jul 8, 2016 at 10:05 AM, Alexandr Scherbatiy
wrote:
> On 7/4/2016 3:14 PM, Mario Torre wrote:
>>
>> On Wed, Jun 29, 2016 at 12:40 PM, Mario Torre wrote:
>>>
>>> Ping?
>>
>> Ping Ping?
>
>
> Just a question. The isGtkSupported is moved to be a local variable. It
> seems its value can't b
Hi Robin,
in your fix there will be extra separator at the end of the text,
you need to put "sb.append(separator);" before "sb.append(strings[i]);"
in for cycle.
Thanks,
Mikhail.
On 08.07.2016 23:06, Robin Stevens wrote:
Please review the fix for JDK-8160941 .
Webrev: http://cr.openjdk.java.n
Hi,
This is the fix for JVM crash bug.
https://bugs.openjdk.java.net/browse/JDK-8159956
Root Cause :
newInsets() method in
java.desktop/windows/native/libawt/windows/ThemeReader.cpp file tries to access
AwtToolkit::insetsMID method id.
In awt headless mode, this
10 matches
Mail list logo
