Re: [9] Review request for JDK-8160266: [macosx] NestedModalDialogTest.java and NestedModelessDialogTest.java tests does not run with current JDK codebase after taking the files fro

Hi Alexandr, Thank you for the review comments. Code is modified as per you suggestion. RobotUtilities class is replaced with direct calls to corresponding methods in Robot class and also Util class is used in some places. Please review the modified code. http://cr.openjdk.java.net/~mhalder/816

Re: [8] Review request JDK-8160941: [macosx]"text/uri-list" dataflavor concats the first two strings

Looks good. On 12.07.2016 0:15, Robin Stevens wrote: Hello Mikhail, good catch. I adjusted the code. Webrev: http://cr.openjdk.java.net/~rstevens/8160941/webrev.01 Robin On Mon, Jul 11, 2016 at 6:08 PM, Mikhail Cherkasov mailto:m

Re: [8] Review request JDK-8160941: [macosx]"text/uri-list" dataflavor concats the first two strings

Hello Mikhail, thanks for the review. Would you mind performing the actual commit once it is approved (I assume I need a review from a second person) ? I have no commit rights, so I cannot do it myself. Thanks Robin On Tue, Jul 12, 2016 at 2:04 PM, Mikhail Cherkasov < mikhail.cherka...@oracle.c

Re: [8] Review request JDK-8160941: [macosx]"text/uri-list" dataflavor concats the first two strings

Alexander, could you please make review it too? Thanks, Mikhail. On 12.07.2016 15:12, Robin Stevens wrote: Would you mind performing the actual commit once it is approved (I assume I need a review from a second person) ?

[9] Review request for 8153512: Taskbar support reported for Xfce4.

Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8153512/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8153512 -- Thanks, Alexander.

Re: [9] Review request for 8153512: Taskbar support reported for Xfce4.

Hi Alexander, I would use a static variable and check it once only. --Semyon On 12.07.2016 16:56, Alexander Zvegintsev wrote: Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8153512/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8153512

Re: [9] Review request for 8153512: Taskbar support reported for Xfce4.

Hi Semyon, please see the updated webrev http://cr.openjdk.java.net/~azvegint/jdk/9/8153512/01/ Thanks, Alexander. On 07/12/2016 05:22 PM, Semyon Sadetsky wrote: Hi Alexander, I would use a static variable and check it once only. --Semyon On 12.07.2016 16:56, Alexander Zvegintsev wrote: He

Re: [9] Review request for 8153512: Taskbar support reported for Xfce4.

Looks good to me. --Semyon On 12.07.2016 17:42, Alexander Zvegintsev wrote: Hi Semyon, please see the updated webrev http://cr.openjdk.java.net/~azvegint/jdk/9/8153512/01/ Thanks, Alexander. On 07/12/2016 05:22 PM, Semyon Sadetsky wrote: Hi Alexander, I would use a static variable and chec

Re: [9] Review request for 8159460: On Ubuntu Unity, problem with java/awt/Window/FindOwner/FindOwnerTest

Looks good to me. -- Thanks, Alexander. On 17.06.2016 11:42, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8159460 webrev: http://cr.openjdk.java.net/~ssadetsky/8159460/webrev.00/ On Unity WM_TAKE_FOCUS notification is sent to the de