Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

2016-07-19 Thread David DeHaven
After having some internal discussions we've decided to set forRemoval to false as we're not certain which release it will be removed in and it's likely to be needed in at least 10. -DrD-

Re: [OpenJDK 2D-Dev] RFR(L): 8160974: [TESTBUG] Mark more headful tests with @key headful.

2016-07-19 Thread Sergey Bylokhov
Look fine to me. On 07.07.16 18:01, Lindenmaier, Goetz wrote: Hi, This change is ‘L’ because there are changes to a lot of files, but the changes are all similar, so it’s rather easy to review. Similar to 8159690 I added @key headful to another around 600 tests. I used different patterns

Re: [9] Review request for 8161007: GPL header missing comma in year - not swapped in licensee bundles

2016-07-19 Thread Alexander Zvegintsev
+1 On 7/19/16 2:28 PM, Alexandr Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 7/15/2016 2:46 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8161007 webrev:

Re: [9] Review request for 8161195: Regression: closed/javax/swing/text/FlowView/LayoutTest.java

2016-07-19 Thread Alexandr Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 7/14/2016 1:05 AM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8161195 webrev: http://cr.openjdk.java.net/~ssadetsky/8161195/webrev.00/ The IMN_SETCOMPOSITIONWINDOW message is

Re: RFR: 8140723: Remove source code conditionalized on JAVASE_EMBEDDED

2016-07-19 Thread David Holmes
Thanks Alexandr! David On 19/07/2016 9:26 PM, Alexandr Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 7/16/2016 2:55 AM, David Holmes wrote: Can I please get someone from AWT to approve this. Thanks, David On 14/07/2016 2:25 PM, David Holmes wrote: The bug report for

Re: [9] Review request for 8161007: GPL header missing comma in year - not swapped in licensee bundles

2016-07-19 Thread Alexandr Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 7/15/2016 2:46 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8161007 webrev: http://cr.openjdk.java.net/~ssadetsky/8161007/webrev.00/ --Semyon

Re: RFR: 8140723: Remove source code conditionalized on JAVASE_EMBEDDED

2016-07-19 Thread Alexandr Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 7/16/2016 2:55 AM, David Holmes wrote: Can I please get someone from AWT to approve this. Thanks, David On 14/07/2016 2:25 PM, David Holmes wrote: The bug report for this is confidential but quite simply all of the little tweaks and knobs we