Re: [9] Review Request JDK-8144594 HiDPI: awt.Choice looks improperly (Win 8)

2016-07-21 Thread Rajeev Chamyal
Hello Sergey, This issue is not there with AwtList. Regards, Rajeev Chamyal -Original Message- From: Sergey Bylokhov Sent: 21 July 2016 14:48 To: Rajeev Chamyal; Alexander Scherbatiy; awt-dev@openjdk.java.net Subject: Re: [9] Review Request JDK-8144594 HiDPI: awt.Choice looks improperl

Re: Review Request: JDK-8144709 [hidpi] [TestBug] java/awt/GridLayout/ChangeGridSize/ChangeGridSize.java, java/awt/GridLayout/ComponentPreferredSize/ComponentPreferredSize.java are failing

2016-07-21 Thread Rajeev Chamyal
Looks good to me.   Regards, Rajeev Chamyal   From: Prem Balakrishnan Sent: 21 July 2016 16:03 To: Rajeev Chamyal; Alexander Scherbatiy; awt-dev@openjdk.java.net Subject: RE: Review Request: JDK-8144709 [hidpi] [TestBug] java/awt/GridLayout/ChangeGridSize/ChangeGridSize.java, java/awt/GridL

Re: Review Request: JDK-8144709 [hidpi] [TestBug] java/awt/GridLayout/ChangeGridSize/ChangeGridSize.java, java/awt/GridLayout/ComponentPreferredSize/ComponentPreferredSize.java are failing

2016-07-21 Thread Prem Balakrishnan
  Hi Rajeev,   Please review Updated patch as per review comments. Webrev: http://cr.openjdk.java.net/~pkbalakr/8144709/webrev.01/     Regards, Prem     From: Rajeev Chamyal Sent: Thursday, July 21, 2016 12:36 PM To: Alexander Scherbatiy; Prem Balakrishnan; awt-dev@openjdk.java.net Sub

Re: [9] Review Request JDK-8144594 HiDPI: awt.Choice looks improperly (Win 8)

2016-07-21 Thread Sergey Bylokhov
Should we apply the same fix to AwtList::PreferredItemSize? On 20.07.16 11:21, Rajeev Chamyal wrote: Hello All, Please review the following webrev. Bug: https://bugs.openjdk.java.net/browse/JDK-8144594 Webrev : http://cr.openjdk.java.net/~rchamyal/8144594/webrev.00 Issue : Awt choice c

Re: Review Request: JDK-8144709 [hidpi] [TestBug] java/awt/GridLayout/ChangeGridSize/ChangeGridSize.java, java/awt/GridLayout/ComponentPreferredSize/ComponentPreferredSize.java are failing

2016-07-21 Thread Rajeev Chamyal
Hello Prem,   Frame should be disposed on exceptions.   Regards, Rajeev Chamyal   From: Alexandr Scherbatiy Sent: 20 July 2016 17:36 To: Prem Balakrishnan; Rajeev Chamyal; awt-dev@openjdk.java.net Subject: Re: Review Request: JDK-8144709 [hidpi] [TestBug] java/awt/GridLayout/ChangeGridSize