Re: Review Request for 8160696: IllegalArgumentException: adding a component to a container on a different GraphicsDevice

Hi Mikhail, Here are few suggestions, Please add @key heedful jtreg tag. Please correct line 74. Use specific class imports instead of package import. Regards, Ambarish -Original Message- From: Mikhail Cherkasov Sent: Wednesday, August 10, 2016 9:26 PM To

Re: RFR(XXS): 8163408: Fix wrong prototype of getNativeScaleFactor() in systemScale.h

Hi Alexandr, sorry, but I saw your answer too late. I just noticed Sergeys review and pushed the fix jdk9/dev already. On Wed, Aug 10, 2016 at 4:40 PM, Alexandr Scherbatiy wrote: > > Calling getNativeScaleFactor(NULL) leads that "com.ubuntu.user-interface" > "scale-factor" and "com.canonical.Uni

Re: RFR(XXS): 8163408: Fix wrong prototype of getNativeScaleFactor() in systemScale.h

Thanks Sergey! Finally I also found out why I couldn't see this problem with other compilers. -Wunprototyped-calls seems to be an undocumented Suse extension which is only available on SLES/OpenSuse GCC builds. Somehow it never made its way into upstream GCC. The only reference I could find is t

Re: Review Request for 8160696: IllegalArgumentException: adding a component to a container on a different GraphicsDevice

Now everything is in place: http://cr.openjdk.java.net/~mcherkas/8160696/webrev.02/test/java/awt/Container/MoveToOtherScreenTest/MoveToOtherScreenTest.java.html On 10.08.2016 18:32, Sergey Bylokhov wrote: but these frames should be disposed

Re: Review Request for 8160696: IllegalArgumentException: adding a component to a container on a different GraphicsDevice

Oops, sorry, I missed this. On 10.08.2016 18:32, Sergey Bylokhov wrote: but these frames should be disposed

Re: Review Request for 8160696: IllegalArgumentException: adding a component to a container on a different GraphicsDevice

On 10.08.16 18:07, Mikhail Cherkasov wrote: Right, it addes it to other frame later: frms[1].add(canvas); Ouch I thought it was dispose of the frame. This fine then, but these frames should be disposed at the end of the test. On 10.08.2016 17:49, Sergey Bylokhov wrote: How this test wi

Re: [9] Review Request JDK-8151787 Unify the HiDPI splash screen image naming convention

On 8/9/2016 11:18 AM, Rajeev Chamyal wrote: Hello All, Please review the following webrev. Bug: https://bugs.openjdk.java.net/browse/JDK-8151787 Webrev: http://cr.openjdk.java.net/~rchamyal/8151787/webrev.00/ Issue: Currently diff

Re: Review Request for 8160696: IllegalArgumentException: adding a component to a container on a different GraphicsDevice

Right, it addes it to other frame later: frms[1].add(canvas); On 10.08.2016 17:49, Sergey Bylokhov wrote: How this test will fail before the fix? since the canvas is added only once "frms[0].add(canvas);" It seems that it should be added to the first and then to the second frame, no? On 10

Re: [9] Review request for 8149115: [hidpi] Linux: display-wise scaling factor should probably be taken into account

It is unclear why gdk_scale is applied on top of native scale? So if both GDK_SCALE and scale-factor are set, then we will get the multiply of them, is it expected? On 08.07.16 13:27, Alexander Zvegintsev wrote: +1 On 7/8/16 10:37 AM, Alexandr Scherbatiy wrote: The fix looks good to me. Th

Re: Review Request for 8160696: IllegalArgumentException: adding a component to a container on a different GraphicsDevice

How this test will fail before the fix? since the canvas is added only once "frms[0].add(canvas);" It seems that it should be added to the first and then to the second frame, no? On 10.08.16 17:38, Mikhail Cherkasov wrote: Hi Sergey, all, There's an update test: http://cr.openjdk.java.net/~mc

Re: RFR(XXS): 8163408: Fix wrong prototype of getNativeScaleFactor() in systemScale.h

Calling getNativeScaleFactor(NULL) leads that "com.ubuntu.user-interface" "scale-factor" and "com.canonical.Unity.Interface" "text-scale-factor" properties are just skipped in getDesktopScale(char *output_name) method from systemScale.c file. Should there be provided some default output scree

Re: Review Request for 8160696: IllegalArgumentException: adding a component to a container on a different GraphicsDevice

Hi Sergey, all, There's an update test: http://cr.openjdk.java.net/~mcherkas/8160696/webrev.01/ Thanks, Mikhail. On 05.08.2016 21:17, Sergey Bylokhov wrote: Hi, Mikhail. Please update the header of the test and rename it to some meaningful name. Also note that the frames should be disposed at

Re: RFR(XXS): 8163408: Fix wrong prototype of getNativeScaleFactor() in systemScale.h

Looks fine. On 09.08.16 10:37, Volker Simonis wrote: I've just send the RFR to the same list on which the offending change 8149115 has been reviewed. But I'm fine with any list, as long as the change gets reviewed :) Regards, Volker On Mon, Aug 8, 2016 at 10:39 PM, Alexander Scherbatiy wrote