Re: [9] Review request for 8162840: Desktop. enableSuddenTermination() has no effect

2016-08-16 Thread Alexander Zvegintsev
Sure, but it is already created by Yuri and attached to the issue. I can include it with this fix, however as far I know SQE has a separate task to cover this JEP with tests and this test is a part of this task. On 8/16/16 7:27 PM, Sergey Bylokhov wrote: Hi, Alexander. Is it possible to

Re: Review Request: JDK-8144735 [hidpi] javax/swing/JWindow/ShapedAndTranslucentWindows/TranslucentPerPixelTranslucentGradient.java fails

2016-08-16 Thread Alexandr Scherbatiy
On 8/16/2016 7:35 AM, Prem Balakrishnan wrote: Reminder *From:*Prem Balakrishnan *Sent:* Friday, August 12, 2016 6:36 PM *To:* Alexander Scherbatiy; Rajeev Chamyal; awt-dev@openjdk.java.net; Sergey Bylokhov *Subject:* RE: Review Request: JDK-8144735 [hidpi]

Re: [9] Review Request JDK-8151787 Unify the HiDPI splash screen image naming convention

2016-08-16 Thread Alexandr Scherbatiy
The fix looks good to me. It would be better if a native speaker look at the documentation change in the launcher.properties file. Thanks, Alexandr. On 8/16/2016 8:26 AM, Rajeev Chamyal wrote: Hello Alexandr, Please review the updated webrev.

Re: [9] Review Request: 8164104 Cleanup of javaclient related mapfiles

2016-08-16 Thread Phil Race
I think "JPRT is OK" is good but may be not enough here? I am not sure if the build will complain about missing entries for JNI methods since there is no direct linking against these. Can you do a quick sanity run through of Java2Demo on Linux .. and ideally Solaris x64 too. -phil. On

Re: [9] Review request for 8162840: Desktop. enableSuddenTermination() has no effect

2016-08-16 Thread Sergey Bylokhov
Hi, Alexander. Is it possible to create a test for the fix? On 16.08.16 19:20, Alexander Zvegintsev wrote: Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8162840/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8162840 We don't call QuitHandler and

[9] Review Request: 8164104 Cleanup of javaclient related mapfiles

2016-08-16 Thread Sergey Bylokhov
Hello. Please review cleanup of mapfiles, initially the problem was found here: http://mail.openjdk.java.net/pipermail/awt-dev/2016-August/011734.html - tabs were replaced by spaces - doubled empty lines removed jprt is ok. Bug: https://bugs.openjdk.java.net/browse/JDK-8164104 Patch can be

[9] Review Request: 8164104 Cleanup of javaclient related mapfiles

2016-08-16 Thread Sergey Bylokhov
Hello. Please review cleanup of mapfiles, initially the problem was found here: http://mail.openjdk.java.net/pipermail/awt-dev/2016-August/011734.html - tabs were replaced by spaces - doubled empty lines removed jprt is ok. Bug: https://bugs.openjdk.java.net/browse/JDK-8164104 Patch can be

[9] Review request for 8162840: Desktop. enableSuddenTermination() has no effect

2016-08-16 Thread Alexander Zvegintsev
Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8162840/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8162840 We don't call QuitHandler and using default QuitStrategy if sudden termination is enabled. -- Thanks, Alexander.

Review Request for 8160056: TextField.setText breaks the contract of EOL

2016-08-16 Thread Ambarish Rapte
Hi, Please review the change for JDK9, Bug: https://bugs.openjdk.java.net/browse/JDK-8160056 Webrev: http://cr.openjdk.java.net/~arapte/8160056/webrev.00/ Change Description: The TextField is a single line text component.