[9] Review request for 8161910: [PIT] regression: HW/LW mixing seems broken on Unity

2016-08-22 Thread Semyon Sadetsky
Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8161910 webrev: http://cr.openjdk.java.net/~ssadetsky/8161910/webrev.00/ A regression of the 8036915 in which a new frame dimensioning algo was introduced for the Unity WM because the latter differs from other WM

Re: [9] Review request for 8162840: Desktop. enableSuddenTermination() has no effect

2016-08-22 Thread Sergey Bylokhov
Ok, then the current fix looks fine. On 17.08.16 10:22, Yuri Nesterenko wrote: In fact, we have a bunch of them in the func. workspace, all more or less easily portable to jtreg. I'll move them in a bulk, time permitting. -yan On 08/16/2016 07:47 PM, Alexander Zvegintsev wrote: Sure, but it

Re: [9] Review Request JDK-8151787 Unify the HiDPI splash screen image naming convention

2016-08-22 Thread Rajeev Chamyal
Hello Phil, Thanks for the review, Please review updated webrev. http://cr.openjdk.java.net/~rchamyal/8151787/webrev.04/ Updated files: src/java.base/share/classes/sun/launcher/resources/launcher.properties src/java.desktop/macosx/native/libsplashscreen/splashscreen_sys.m src/java.desktop/macosx/n

Re: [9] Review request for 8149115: [hidpi] Linux: display-wise scaling factor should probably be taken into account

2016-08-22 Thread Sergey Bylokhov
On 22.08.16 11:33, Semyon Sadetsky wrote: It is unclear why gdk_scale is applied on top of native scale? So if both GDK_SCALE and scale-factor are set, then we will get the multiply of them, is it expected? yes. GDK_SCALE is to scale gtklib based apps. Desktop scale is a separate scale. So if

Re: [9] Review request for 8149115: [hidpi] Linux: display-wise scaling factor should probably be taken into account

2016-08-22 Thread Semyon Sadetsky
On 8/10/2016 5:54 PM, Sergey Bylokhov wrote: It is unclear why gdk_scale is applied on top of native scale? So if both GDK_SCALE and scale-factor are set, then we will get the multiply of them, is it expected? yes. GDK_SCALE is to scale gtklib based apps. Desktop scale is a separate scale.

8138771: java.awt.image.AbstractMultiResolutionImage needs customized spec for methods of Image which it implements

2016-08-22 Thread Avik Niyogi
+ awt-dev > On 22-Aug-2016, at 12:28 pm, Avik Niyogi wrote: > > Hi All, > > Kindly review the proposed specifications for JDK9. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8138771 > > > Webrev: http://cr.openjdk.java.net/~aniyogi/813

Re: Review Request: JDK-8144735 [hidpi] javax/swing/JWindow/ShapedAndTranslucentWindows/TranslucentPerPixelTranslucentGradient.java fails

2016-08-22 Thread Prasanta Sadhukhan
I wonder how it compiles? I tried a small program -- public class Test { AccelSurface b = new AccelSurface(); SurfaceData c = (SurfaceData)b; } class SurfaceData extends Surface {} class Surface {} class AccelSurface extends Surface {} - and it fails to com