Re: [9] Review request for 8163101: dual-screen issue with JMenu, JPopupMenu

2016-08-31 Thread Sergey Bylokhov
On 31.08.16 17:18, Semyon Sadetsky wrote: Toolkit.getDefaultToolkit().getScreenSize() was replaced by graphicsConfig.getBounds(); that returns a particular screen area which is not the same as the joint screen area in case of Xinerama multi-monitor configuration. Can you please clarify what

Re: Review request for 8160570: [mac] modal dialog can skip the activation/focus events

2016-08-31 Thread Sergey Bylokhov
On 30.08.16 18:18, Anton Tarasov wrote: As I wrote in JIRA, the problem is caused by the fact that a native window (for a modal dialog) is shown before the peer starts to show. (This seems strange, and you can investigate the reason, I’m not aware) Maybe because NSWindow.orderFrontRegardless() i

Re: Review request for 8160570: [mac] modal dialog can skip the activation/focus events

2016-08-31 Thread Semyon Sadetsky
+1 --Semyon On 8/31/2016 5:25 PM, Anton Tarasov wrote: On 8/30/2016 7:05 PM, Semyon Sadetsky wrote: On 8/30/2016 6:18 PM, Anton Tarasov wrote: Hi Semyon, On 8/29/2016 9:08 PM, Semyon Sadetsky wrote: On 8/29/2016 8:29 PM, Anton Tarasov wrote: Hi Semyon, As I wrote in JIRA, the problem

Re: Review request for 8160570: [mac] modal dialog can skip the activation/focus events

2016-08-31 Thread Anton Tarasov
On 8/30/2016 7:05 PM, Semyon Sadetsky wrote: On 8/30/2016 6:18 PM, Anton Tarasov wrote: Hi Semyon, On 8/29/2016 9:08 PM, Semyon Sadetsky wrote: On 8/29/2016 8:29 PM, Anton Tarasov wrote: Hi Semyon, As I wrote in JIRA, the problem is caused by the fact that a native window (for a modal di

[9] Review request for 8163101: dual-screen issue with JMenu, JPopupMenu

2016-08-31 Thread Semyon Sadetsky
Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8163101 webrev: http://cr.openjdk.java.net/~ssadetsky/8163101/webrev.00/ In the 8137571 the available screen area request Toolkit.getDefaultToolkit().getScreenSize() was replaced by graphicsConfig.getBounds();

Re: [9] Review request for 8163100: [hidpi] Linux: display-wise scaling factor issues

2016-08-31 Thread Sergey Bylokhov
Looks fine. On 31.08.16 11:11, Semyon Sadetsky wrote: On 8/30/2016 11:57 PM, Sergey Bylokhov wrote: Why in X11GraphicsDevice.java we cannot call initScaleFactor() directly without isUIScaleEnabled() check like we do on win/osx? The same check is made inside this method. don't see why this che

Re: [9] Review request for 8163100: [hidpi] Linux: display-wise scaling factor issues

2016-08-31 Thread Semyon Sadetsky
On 8/30/2016 11:57 PM, Sergey Bylokhov wrote: Why in X11GraphicsDevice.java we cannot call initScaleFactor() directly without isUIScaleEnabled() check like we do on win/osx? The same check is made inside this method. don't see why this check is bad, but since it is not very necessary I have re