Re: RFR: JDK-8165232 XKeycodeToKeysym is deprecated and should be replaced with XkbKeycodeToKeysym

2016-09-06 Thread Alan Burlison
On 06/09/2016 21:42, Phil Race wrote: These are all internal-only entry points So if that exists (I did not know that it did) then I think you have a few options but the most forward looking is to get rid of all references to the deprecated methods and migrate all uses (inc. Java land ones) to t

Re: RFR: JDK-8165232 XKeycodeToKeysym is deprecated and should be replaced with XkbKeycodeToKeysym

2016-09-06 Thread Phil Race
On 9/6/2016 1:14 PM, Alan Burlison wrote: On 06/09/2016 20:29, Phil Race wrote: You are removing this : native method Java_sun_awt_X11_XlibWrapper_XKeycodeToKeysym There is no explanation about this .. and unless you discovered this method is obsolete (never called) it seems like it should als

Re: RFR: JDK-8165232 XKeycodeToKeysym is deprecated and should be replaced with XkbKeycodeToKeysym

2016-09-06 Thread Alan Burlison
On 06/09/2016 20:29, Phil Race wrote: You are removing this : native method Java_sun_awt_X11_XlibWrapper_XKeycodeToKeysym There is no explanation about this .. and unless you discovered this method is obsolete (never called) it seems like it should also be updated .. not deleted. And since I se

Re: RFR: JDK-8165232 XKeycodeToKeysym is deprecated and should be replaced with XkbKeycodeToKeysym

2016-09-06 Thread Phil Race
Alan, You are removing this : native method Java_sun_awt_X11_XlibWrapper_XKeycodeToKeysym There is no explanation about this .. and unless you discovered this method is obsolete (never called) it seems like it should also be updated .. not deleted. And since I see it called from XToolkit.java

[9] Review request for 8153526: [Unity] Taskbar.getTaskbar().setMenu(null) doesn't remove menu

2016-09-06 Thread Alexander Zvegintsev
Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8153526/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8153526 -- Thanks, Alexander.

RFR: JDK-8165232 XKeycodeToKeysym is deprecated and should be replaced with XkbKeycodeToKeysym

2016-09-06 Thread Alan Burlison
XKeycodeToKeysym is deprecated and when compiled on Solaris 12 with warnings-as-errors this causes a compile time failure. References to XKeycodeToKeysym should be replaced by XkbKeycodeToKeysym. As this is common XOrg code it will affect Linux as well. Bug:https://bugs.openjdk.java.net/br

[9] Review request for 8143914: Provide Mac-specific fullscreen support

2016-09-06 Thread Alexander Zvegintsev
Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8143914/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8143914 This fix adds the green FullScreen button to a resizable frames by default. Previous maximize behavior is still accessible by holding Alt while

Re: [9] Review Request JDK-8149371 multi-res. image: -Dsun.java2d.uiScale does not work for Window icons (some ambiguity for Window.setIconImages

2016-09-06 Thread Alexandr Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 9/6/2016 1:30 PM, Rajeev Chamyal wrote: Hello Alexander, Thanks for the review.I have updated webrev as per review comments. http://cr.openjdk.java.net/~rchamyal/8149371/webrev.01/ R

Re: [9] Review Request JDK-8149371 multi-res. image: -Dsun.java2d.uiScale does not work for Window icons (some ambiguity for Window.setIconImages

2016-09-06 Thread Rajeev Chamyal
Hello Alexander, Thanks for the review.I have updated webrev as per review comments. http://cr.openjdk.java.net/~rchamyal/8149371/webrev.01/ Regards, Rajeev Chamyal From: Alexandr Scherbatiy Sent: 05 September 2016 16:04 To: Rajeev Chamyal; Sergey Bylokhov; awt-dev@openjdk.java.net S

RFR: JDK-8165232 XKeycodeToKeysym is deprecated and should be replaced with XkbKeycodeToKeysym

2016-09-06 Thread Alan Burlison
XKeycodeToKeysym is deprecated and when compiled on Solaris 12 with warnings-as-errors this causes a compile time failure. References to XKeycodeToKeysym should be replaced by XkbKeycodeToKeysym. As this is common XOrg code it will affect Linux as well. Bug:https://bugs.openjdk.java.net/br

Re: Review request for 8160570: [mac] modal dialog can skip the activation/focus events

2016-09-06 Thread Anton Tarasov
On 9/5/2016 8:11 PM, Sergey Bylokhov wrote: On 01.09.16 17:22, Anton Tarasov wrote: but both frames are still visible. This is why I wonder, how did you close it in the app. You probably missed the fact the dialog is modal. O_o, correct. No more comments from me. Looks fine. Thanks for the f