Re: [9] Review Request: 8004693 TEST_BUG: java/awt/KeyboardFocusmanager/DefaultPolicyChange/DefaultPolicyChange_Swing.java fails

2016-09-13 Thread Alexander Zvegintsev
Looks good to me. On 5/30/16 7:39 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. The test DefaultPolicyChange_Swing.java has two issues: - It uses invokeLater(), so the test usually pass before the code is executed on the EDT, because the main thread completes before. -

[9] Review request for 8140311: SwingInterop crashes at window close

2016-09-13 Thread Alexander Zvegintsev
Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8140311/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8140311 This issue is only reproducible when a window using CWarningWindow. After window close we cancel HidingTask in CWarningWindow at java level,

Re: [9] Review Request JDK-8151787 Unify the HiDPI splash screen image naming convention

2016-09-13 Thread Rajeev Chamyal
Hello Phil, Please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8151787/webrev.09/ Updates: Updated documentation in src/java.desktop/share/classes/java/awt/SplashScreen.java Review comments from Kumar are also updated in launcher.properties. Regards, Rajeev Chamyal