Re: [9] Review Request JDK-8151787 Unify the HiDPI splash screen image naming convention

2016-10-03 Thread Phil Race
+1 -phil. On 09/21/2016 02:29 AM, Rajeev Chamyal wrote: Hello Phil, Please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8151787/webrev.10/ Updates: Updated launcher.properties as suggested. Regards, Rajeev Ch

Re: [9] Review Request for 8141528: Test closed/java/awt/FullScreen/DisplayMode/CycleDMImage.java fails for Ubuntu 15.10

2016-10-03 Thread Alexander Zvegintsev
Looks fine. -- Thanks, Alexander. On 10/03/2016 07:38 PM, Semyon Sadetsky wrote: The fix is updated http://cr.openjdk.java.net/~ssadetsky/8141528/webrev.01/ The root case of the issue is that in Unity the screen window size and location are get updated several times after display mode is cha

Re: RFR: JDK-8165232 XKeycodeToKeysym is deprecated and should be replaced with XkbKeycodeToKeysym

2016-10-03 Thread Phil Race
Do we have a 2nd reviewer yet ? I have not seen it. -phil. On 10/03/2016 08:21 AM, Alan Burlison wrote: On 30/09/2016 20:01, Phil Race wrote: Our helpful SQE engineer has verified that this works as well as previously. And I've done some basic testing myself on Ubuntu 16.04, so "+1" (meaning

Re: [9] Review Request for 8141528: Test closed/java/awt/FullScreen/DisplayMode/CycleDMImage.java fails for Ubuntu 15.10

2016-10-03 Thread Semyon Sadetsky
The fix is updated http://cr.openjdk.java.net/~ssadetsky/8141528/webrev.01/ The root case of the issue is that in Unity the screen window size and location are get updated several times after display mode is changed, and bounds which are set in line 459 of X11GraphicsDevice class are overwritt

Re: [9] Review request for 8159432: [PIT][macosx] StackOverflow in closed/java/awt/Dialog/DialogDeadlock/DialogDeadlockTest

2016-10-03 Thread Alexander Zvegintsev
looks good to me. -- Thanks, Alexander. On 24.08.2016 22:18, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8159432 webrev: http://cr.openjdk.java.net/~ssadetsky/8159432/webrev.00/ The issue is connected to the restoring focus to the

Re: RFR: JDK-8165232 XKeycodeToKeysym is deprecated and should be replaced with XkbKeycodeToKeysym

2016-10-03 Thread Alan Burlison
On 30/09/2016 20:01, Phil Race wrote: Our helpful SQE engineer has verified that this works as well as previously. And I've done some basic testing myself on Ubuntu 16.04, so "+1" (meaning approved). Thanks. Could someone sponsor this for me? -- Alan Burlison --