Re: [9] Review request for JDK-8165555: [macosx] VM crashes on second attempt to execute JCK interactive tests that use Robot (single JVM, agent)

2016-10-04 Thread Manajit Halder
Hi Sergey, Thanks for the review. Changes in CRobot.m are removed and added a jtreg test case. Please review the webrev. http://cr.openjdk.java.net/~mhalder/816/webrev.03/ Thanks, Manajit > On 27-Sep-2016, at 4:15 pm, Sergey Bylokho

Re: [9] Review request for 8166591 [macos 10.12] Trackpad scrolling of text on OS X 10.12 Sierra is very fast (Trackpad, Retina only)

2016-10-04 Thread Sergey Malenkov
Hi all, Message from Mike Swingler about sensitive scrolling: >The original issue your bug was duplicated against > has been resolved by the HID engineering team, > and should be available in a forthcoming beta of > macOS 10.12.1. To get it via Software Update, > sign up at

Re: RFR: JDK-8165232 XKeycodeToKeysym is deprecated and should be replaced with XkbKeycodeToKeysym

2016-10-04 Thread Alan Burlison
On 03/10/2016 22:08, Phil Race wrote: Do we have a 2nd reviewer yet ? I have not seen it. Gah you are right, I thought I'd seen a 2nd. Any takers? -- Alan Burlison --

Re: [9] Fix for JDK-8058950 : [TESTBUG] There is no F1 dialog when the case loading, so we can't restore it.

2016-10-04 Thread Ambarish Rapte
Hi Ajit, The changes look fine to me. Regards, Ambarish -Original Message- From: Sergey Bylokhov Sent: Friday, September 30, 2016 5:21 PM To: Ajit Ghaisas; awt-dev@openjdk.java.net; Semyon Sadetsky; Ambarish Rapte Subject: Re: [9] Fix for JDK-8058950 : [TESTBUG] There is no F1 di

Re: [9] Review request for JDK-8165555: [macosx] VM crashes on second attempt to execute JCK interactive tests that use Robot (single JVM, agent)

2016-10-04 Thread Sergey Bylokhov
Hi, Manajit. It looksbetter, bet it can be improved a little bit. - you should not skip exceptions in the run(); - It will be good to select the frame by mouse click before pressing the key, otherwise you can run somthing else. - I suggest to iterate the code in main a few times in the loop(I

Re: [9] Review Request for 8141528: Test closed/java/awt/FullScreen/DisplayMode/CycleDMImage.java fails for Ubuntu 15.10

2016-10-04 Thread Sergey Bylokhov
Hi, Semyon. - It seems that DisplayMode contain the data which were not upscaled to the units instead of pixels. It seems incorrect that it is necessary to convert them here to set the correct size for the window. - Is it possible to eliminate check for Unity? I guess that if the size of mode

Re: [9] Review Request for 8141528: Test closed/java/awt/FullScreen/DisplayMode/CycleDMImage.java fails for Ubuntu 15.10

2016-10-04 Thread Semyon Sadetsky
On 10/4/2016 4:05 PM, Sergey Bylokhov wrote: Hi, Semyon. - It seems that DisplayMode contain the data which were not upscaled to the units instead of pixels. It seems incorrect that it is necessary to convert them here to set the correct size for the window. Not sure that it is true. Display

Re: [9] Review request for 8166591 [macos 10.12] Trackpad scrolling of text on OS X 10.12 Sierra is very fast (Trackpad, Retina only)

2016-10-04 Thread Sergey Malenkov
I've got old MacBook Air 2011, 11" non-Retina display. I installed Sierra and reproduced the fast scrolling issue. Now I have no idea when it can be reproduced and when cannot. Then I installed 10.12.1 beta (16B2333a). Seems that the issue is not reproducible with a system terminal anymore, but

Re: RFR: JDK-8165232 XKeycodeToKeysym is deprecated and should be replaced with XkbKeycodeToKeysym

2016-10-04 Thread Alexander Zvegintsev
Hello, as I can see there is a memory leak in case when the index is greater than or equal to num_syms: 837 KeySym *key_syms = XGetKeyboardMapping(display, keycode, 1, &num_syms); 838 if (index >= num_syms) { 839 return NoSymbol; 840 } key_syms is not freed. -- Thanks, Alexander. On 10/4/1

Re: RFR: JDK-8165232 XKeycodeToKeysym is deprecated and should be replaced with XkbKeycodeToKeysym

2016-10-04 Thread Alan Burlison
On 04/10/16 17:34, Alexander Zvegintsev wrote: as I can see there is a memory leak in case when the index is greater than or equal to num_syms: 837 KeySym *key_syms = XGetKeyboardMapping(display, keycode, 1, &num_syms); 838 if (index >= num_syms) { 839 return NoSymbol; 840 } key_syms is not fr

Re: [9] Review Request for 8141528: Test closed/java/awt/FullScreen/DisplayMode/CycleDMImage.java fails for Ubuntu 15.10

2016-10-04 Thread Sergey Bylokhov
On 04.10.16 16:27, Semyon Sadetsky wrote: On 10/4/2016 4:05 PM, Sergey Bylokhov wrote: Hi, Semyon. - It seems that DisplayMode contain the data which were not upscaled to the units instead of pixels. It seems incorrect that it is necessary to convert them here to set the correct size for the

Re: [9] Review request for 8163101: dual-screen issue with JMenu, JPopupMenu

2016-10-04 Thread Sergey Bylokhov
On 29.09.16 23:40, Semyon Sadetsky wrote: The usage of toolkit method here is incorrect, adding it again in this patch is also incorrect. The usage of GC which you remove is correct and should be preserved. I don't understand what you call correct and what incorrect. But "the usage of GC" result

Re: [9] Review request for 8159432: [PIT][macosx] StackOverflow in closed/java/awt/Dialog/DialogDeadlock/DialogDeadlockTest

2016-10-04 Thread Sergey Bylokhov
On 24.08.16 22:18, Semyon Sadetsky wrote: The issue is connected to the restoring focus to the previously focused window when there are a lot of focus restore requests are coming very often (for example series of windows showing and hiding quickly). In this case waiting for asynchronous focus cau