Re: [9] Review request for 8166594: Taskbar.setWindowProgressValue() spec does not specify expected visual behavior of setWindowProgressValue()

2016-10-05 Thread Semyon Sadetsky
Hi Alexander, 416 * Note that the behavior is undefined when multiple windows is grouped in the task area. Isn't the above a some kind of simplification? Could you reformat changed lines to make them following the 80 chars maximum? --Semyon On 06.10.2016 04:56, Alexander Zvegintsev

[9] Review request for 8166942: Usage of SplashScreen Functions hangs up FX Application

2016-10-05 Thread Alexander Zvegintsev
Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8166942/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8166942 SplashEventLoop() acquires the lock[0] and then trying to call SplashRedrawWindow() which is trying execute some code on the main thread[1]. Thu

[9] Review request for 8166594: Taskbar.setWindowProgressValue() spec does not specify expected visual behavior of setWindowProgressValue()

2016-10-05 Thread Alexander Zvegintsev
Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8166594/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8166594 It also fixes two issues to conform the documentation: setting value below 0 doesn't disable progress indication switching from indeterminate t

8167126: Create a module to provide access to non-SE desktop APIs

2016-10-05 Thread Phil Race
Webrev : http://cr.openjdk.java.net/~prr/8167126/ The upcoming jigsaw changes to limit use of setAccessible [1] mean that some work-arounds for non-SE API users will be broken. To provide for continued access to the capability (albeit via a different package+class name) this fix adds a jdk.deskto

[8u-dev] Review request for 8166591 [macos 10.12] Trackpad scrolling of text on OS X 10.12 Sierra is very fast (Trackpad, Retina only)

2016-10-05 Thread Alexandr Scherbatiy
Just corrected the subject to 8u-dev. Thanks, Alexandr. 05.10.2016 22:46, Alexandr Scherbatiy пишет: Hello, Could you review the backport of the fix to the JDK8u-dev: http://cr.openjdk.java.net/~alexsch/8166591/webrev-jdk8.00 This is just the same fix as for the JDK 9 (see [1])

[8-dev] Review request for 8166591 [macos 10.12] Trackpad scrolling of text on OS X 10.12 Sierra is very fast (Trackpad, Retina only)

2016-10-05 Thread Alexandr Scherbatiy
Hello, Could you review the backport of the fix to the JDK8u-dev: http://cr.openjdk.java.net/~alexsch/8166591/webrev-jdk8.00 This is just the same fix as for the JDK 9 (see [1]). There are some style differences between JDK 8u-dev and JDK 9 which I needed to merge manually. All logic i

Re: [9] Review request for 8166591 [macos 10.12] Trackpad scrolling of text on OS X 10.12 Sierra is very fast (Trackpad, Retina only)

2016-10-05 Thread Sergey Bylokhov
On 30.09.16 20:36, Sergey Malenkov wrote: The updated version where the brgining threshold is set to 0.5: http://cr.openjdk.java.net/~alexsch/8166591/webrev.09 Thank you. Looks good. +1 Could you please look at the attached patch for 8u? I used it with our custom jdk to test the behav

Re: [9] Review request for JDK-8165555: [macosx] VM crashes on second attempt to execute JCK interactive tests that use Robot (single JVM, agent)

2016-10-05 Thread Manajit Halder
Hi Sergey, Thanks for the comments. Please review the updated webrev. http://cr.openjdk.java.net/~mhalder/816/webrev.04/ The “frame” can’t be a local variable as it is used in two different threads inside the function. Thanks, Manaji

Re: [9] Review request for 8159432: [PIT][macosx] StackOverflow in closed/java/awt/Dialog/DialogDeadlock/DialogDeadlockTest

2016-10-05 Thread Semyon Sadetsky
On 05.10.2016 03:04, Sergey Bylokhov wrote: On 24.08.16 22:18, Semyon Sadetsky wrote: The issue is connected to the restoring focus to the previously focused window when there are a lot of focus restore requests are coming very often (for example series of windows showing and hiding quickly).

Re: [9] Review request for 8163101: dual-screen issue with JMenu, JPopupMenu

2016-10-05 Thread Semyon Sadetsky
On 05.10.2016 02:47, Sergey Bylokhov wrote: On 29.09.16 23:40, Semyon Sadetsky wrote: The usage of toolkit method here is incorrect, adding it again in this patch is also incorrect. The usage of GC which you remove is correct and should be preserved. I don't understand what you call correct a

Re: [9] Review Request for 8141528: Test closed/java/awt/FullScreen/DisplayMode/CycleDMImage.java fails for Ubuntu 15.10

2016-10-05 Thread Semyon Sadetsky
On 05.10.2016 01:53, Sergey Bylokhov wrote: On 04.10.16 16:27, Semyon Sadetsky wrote: On 10/4/2016 4:05 PM, Sergey Bylokhov wrote: Hi, Semyon. - It seems that DisplayMode contain the data which were not upscaled to the units instead of pixels. It seems incorrect that it is necessary to conv