Re: 8138771: java.awt.image.AbstractMultiResolutionImage needs customized spec for methods of Image which it implements

2016-10-26 Thread Jim Graham
The "@return" tags should not start with "returns" in the text. Also, in the @return for getProperty(), insert a word "the" as "the property of the base image"... ...jim On 10/26/16 12:36 AM, Avik Niyogi wrote: Hi All, Please review the proposed specification for

Re: [9] Review Request: 8143077 Deprecate InputEvent._MASK in favor of InputEvent._DOWN_MASK

2016-10-26 Thread Semyon Sadetsky
On 10/26/2016 6:43 PM, Sergey Bylokhov wrote: On 25.10.16 18:46, Semyon Sadetsky wrote: I wonder why he should decide that the old code can be "simply replaced" by the new one? I suppose that at least he should read the specification of the new extended API. There is no notion that this api

Re: [9] Review Request: 8143077 Deprecate InputEvent._MASK in favor of InputEvent._DOWN_MASK

2016-10-26 Thread Sergey Bylokhov
On 25.10.16 18:46, Semyon Sadetsky wrote: I wonder why he should decide that the old code can be "simply replaced" by the new one? I suppose that at least he should read the specification of the new extended API. There is no notion that this api is replaced by the new one, there is a

Re: [9] Review request for 8167652: Making a frame/dialog resizeble/unresizeble shifts its position on Unity.

2016-10-26 Thread Semyon Sadetsky
Please review the updated fix: http://cr.openjdk.java.net/~ssadetsky/8167652/webrev.01/ - unnecessary AWT locks are removed - client code calls are taken away from AWT lock blocks - some design improvements are made --Semyon On 10/19/2016 8:38 PM, Sergey Bylokhov wrote: Hi, Semyon. A few

8138771: java.awt.image.AbstractMultiResolutionImage needs customized spec for methods of Image which it implements

2016-10-26 Thread Avik Niyogi
Hi All, Please review the proposed specification for JDK9 including inputs from reviver reviews. cr.openjdk.java.net/~aniyogi/8138771/webrev.03/ Thank you in advance. With Regards, Avik Niyogi

Re: Review Request : JDK-8168292 [TestBug]Test java/awt/TrayIcon/DragEventSource/DragEventSource.java fails on OS X

2016-10-26 Thread Prasanta Sadhukhan
Hi Prem, +1 to 8168292 but one thing is that this issue is created to enable to work on 8168291 and was mentioned that the problem DragEventSource fails on osx will be addressed as part of 8168292 which I do not see being done in your webrev. So, either open up 8168291 or fix it in this bug.