Re: Review Request For 8160766: [TEST_BUG] java/awt/Focus/DisposedWindow

Looks good. Regards, Ajit -Original Message- From: Sergey Bylokhov Sent: Thursday, November 03, 2016 4:08 PM To: Ambarish Rapte; Ajit Ghaisas; Semyon Sadetsky; awt-dev@openjdk.java.net Subject: Re: Review Request For 8160766: [TEST_BUG] java/awt/Focus/DisposedWindow HI, Ambarish. Looks

Re: [9] Review request for JDK-7153700: [macosx] add support for MouseMotionListener to the TrayIcon

Looks fine. On 03.11.16 14:13, Manajit Halder wrote: Hi Sergey, Thank you for the review comment. Code is modified as per the comment. Please review the modified webrev: http://cr.openjdk.java.net/~mhalder/7153700/webrev.02/ Thanks, Manajit On 27-Oct-2016, at 5:05 pm, Sergey Bylokhov mailto

Re: [9] Review request for JDK-7153700: [macosx] add support for MouseMotionListener to the TrayIcon

Hi Sergey, Thank you for the review comment. Code is modified as per the comment. Please review the modified webrev: http://cr.openjdk.java.net/~mhalder/7153700/webrev.02/ Thanks, Manajit > On 27-Oct-2016, at 5:05 pm, Sergey Bylokhov

Re: 8138771: java.awt.image.AbstractMultiResolutionImage needs customized spec for methods of Image which it implements

The fix looks good to me. Thanks, Alexandr. On 10/31/2016 9:31 PM, Jim Graham wrote: Looks good. +1 ...jim On 10/30/16 11:53 PM, Avik Niyogi wrote: Hi All, Please review the proposed specification for JDK9 including inputs from reviewer reviews. *cr.openjdk.java.net/~aniyogi/813877

Re: Review Request For 8160766: [TEST_BUG] java/awt/Focus/DisposedWindow

HI, Ambarish. Looks fine, but it seems that you need to make buttonReceivedFocus volatile, since you write/read it from the different thread. You can do this just before the push. On 27.10.16 18:21, Ambarish Rapte wrote: Hi All, Please review this test bug fix.

Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot

On 11/2/2016 1:57 PM, Prem Balakrishnan wrote: Hi Alexander, Please review updated patch. http://cr.openjdk.java.net/~pkbalakr/8162959/webrev.01/ Added a new public API “*Image createHiDPIScreenCapture(Rectangle screenRect)”.* *

Re: Fix for JDK-8160146 : Resolve disabled GCC warning 'deprecated-declarations' for libawt_xawt

On 02.11.16 10:01, Ajit Ghaisas wrote: Can I get another +1 for this fix? +1 Regards, Ajit -Original Message- From: Erik Joelsson Sent: Thursday, October 27, 2016 3:30 PM To: Ajit Ghaisas; build-...@openjdk.java.net; awt-dev@openjdk.java.net Subject: Re: Fix for JDK-8160146 : Resolve

Re: [9] Review request for 8163101: dual-screen issue with JMenu, JPopupMenu

+1 Thanks, Alexander. On 8/31/16 5:18 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8163101 webrev: http://cr.openjdk.java.net/~ssadetsky/8163101/webrev.00/ In the 8137571 the available screen area request Toolkit.getDefaultTool

Re: [9] Review request for 8143914: Provide Mac-specific fullscreen support

+1 --Semyon On 03.11.2016 03:20, Sergey Bylokhov wrote: I guess we can extract some of the common logic in the fix, upto other reviewers, this looks fine to me. On 25.10.16 19:25, Alexander Zvegintsev wrote: Please see the updated webrev: http://cr.openjdk.java.net/~azvegint/jdk/9/8143914/