[9] Review request for 8166683: On macOS (Mac OS X) getting a ScreenMenuBar when not running "com.apple.laf.AquaLookAndFeel"

2016-11-09 Thread Alexander Zvegintsev
Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8166683/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8166683 This fix adds support for ScreenMenuBar for L's other than Aqua. With this fix it is enabled by default if apple.laf.useScreenMenuBar property

Re: Review Request For 8160766: [TEST_BUG] java/awt/Focus/DisposedWindow

2016-11-09 Thread Sergey Bylokhov
Hi, Ambarish It seems that the different version was pushed: http://hg.openjdk.java.net/jdk9/client/jdk/rev/88faebbdbf9b The html file still present in ws, and caused a warning from jtreg, because two tests(in .java and .html files) have the same name. On 27.10.16 18:21, Ambarish Rapte wrote:

Re: Fix for JDK-8169043 : The task bar icon color is not blue

2016-11-09 Thread Sergey Bylokhov
Looks fine. On 09.11.16 14:36, Ajit Ghaisas wrote: Hi, Request you to review a test fix. Bug : https://bugs.openjdk.java.net/browse/JDK-8169043 Fix : http://cr.openjdk.java.net/~aghaisas/8169043/webrev.0/ Changes are : 1) Test is made to be run on Windows only. 2)

Fix for JDK-8169043 : The task bar icon color is not blue

2016-11-09 Thread Ajit Ghaisas
Hi, Request you to review a test fix. Bug : https://bugs.openjdk.java.net/browse/JDK-8169043 Fix : http://cr.openjdk.java.net/~aghaisas/8169043/webrev.0/ Changes are : 1) Test is made to be run on Windows only. 2) Pass/Fail status was not reported correctly. It has been

Re: [9] Review request for 8169355: Diacritics input works incorrectly on Windows if Spanish (Latin American) keyboard layout is used

2016-11-09 Thread Semyon Sadetsky
Looks good. --Semyon On 09.11.2016 13:36, dmitry markov wrote: Hello, Could you review a fix for jdk9, please? bug: https://bugs.openjdk.java.net/browse/JDK-8169355 webrev: http://cr.openjdk.java.net/~dmarkov/8169355/webrev.00/ Problem description: The new mechanism of dead keys

[9] Review request for 8169355: Diacritics input works incorrectly on Windows if Spanish (Latin American) keyboard layout is used

2016-11-09 Thread dmitry markov
Hello, Could you review a fix for jdk9, please? bug: https://bugs.openjdk.java.net/browse/JDK-8169355 webrev: http://cr.openjdk.java.net/~dmarkov/8169355/webrev.00/ Problem description: The new mechanism of dead keys detection and processing was introduced by JDK-8139189