Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

2016-12-06 Thread Lindenmaier, Goetz
Hi Phil, does that mean I can push the change, or will this happen through jprt? Best regards, Goetz. > -Original Message- > From: Philip Race [mailto:philip.r...@oracle.com] > Sent: Tuesday, December 06, 2016 4:21 AM > To: Lindenmaier, Goetz > Cc: Sergey Bylokhov ; awt- > d...@openj

Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot

2016-12-06 Thread Prem Balakrishnan
Hi Alexander, Please review updated patch as per review comments. http://cr.openjdk.java.net/~pkbalakr/8162959/webrev.03/ Regards, Prem From: Alexandr Scherbatiy Sent: Monday, November 21, 2016 8:10 PM To: Prem Balakrishnan; Sergey Bylokhov; awt-dev@openjdk.java.net; Phil Race Sub

Re: [9] Review request for 8165428: Security Warning dialog should be always on the top when multiple applets with APPLICATION_MODAL dialog launched in a browser

2016-12-06 Thread Sergey Bylokhov
This logic looks better by it is unclear why you increase the toolkit’s counter? [AWTToolkit eventCountPlusPlus]; This counter should be increased in the native callbacks and should indicate that there are some activity on the toolkit thread. But it seems it is unnecessary in the new isBlocked()

Re: Fwd: [PATCH]: few memory errors fixes

2016-12-06 Thread Lindenmaier, Goetz
Hi, the fix to imageDecompressor.cpp is already reported in https://bugs.openjdk.java.net/browse/JDK-8170663 I'll send RFR for that today. I'll add you to contributors. Best regards, Goetz. > -Original Message- > From: awt-dev [mailto:awt-dev-boun...@openjdk.java.net] On Behalf Of > V

Fwd: [PATCH]: few memory errors fixes

2016-12-06 Thread Volker Simonis
Hi David, thanks for your contribution. Your fixes look reasonable. I'm forwarding your mail to to core-libs-dev and awt-dev for reviewing. Regards, Volker -- Forwarded message -- From: David CARLIER Date: Mon, Dec 5, 2016 at 10:10 PM Subject: [PATCH]: few memory errors fixes T