Re: [awt-dev] Request for Approval and Review: JDK-8140329 [TEST BUG] java/awt/SplashScreen/FullscreenAfterSplash/FullScreenAfterSplash.java

Hi Ambarish, omitted unused file GenerateTestImage.java from the patch. http://cr.openjdk.java.net/~vagarwal/8140329/webrev_03/ -Regards, Rahul Singh On 2017-01-11 1:40 PM, Ambarish Rapte wrote: Hi Rahul, Fix looks good. But I think the file /GenerateTestImage.java/**should be omitted

Re: Proposal on enhancing MouseWheelEvent to include absolute scrolling delta

H, Pavel. Thanks for this proposal. First of all if you have a plan to implement smooth scrolling in the jdk9, then it will be good to use only existing API. (We already had a the feature freeze). So for now a solution will be better to implement the fix via getPreciseWheelRotation

Re: [9] Review request for 8171909: [PIT] on Windows, failure of java/awt/Dialog/DialogAboveFrame/DialogAboveFrameTest.java

Looks fine. Yuri can you please take a look also? Thanks. > > Hello, > > Could you review a fix for jdk9, please? > > bug: https://bugs.openjdk.java.net/browse/JDK-8171909 > > webrev:

Re: [9] Review request for 8165705: Robot.createScreenCapture produces black screenshot on Oracle Linux 7.1

Looks fine to me. Thanks. > > Sure, updated in place. > Thanks, > > Alexander. > On 01/09/2017 06:09 PM, Sergey Bylokhov wrote: >> Looks fine. >> But it seems that this field can be removed? >> private static boolean isGtkSupported = false; >> After the fix for JDK-8150954 this field is not

Re: [awt-dev] Request for Approval and Review: JDK-8140329 [TEST BUG] java/awt/SplashScreen/FullscreenAfterSplash/FullScreenAfterSplash.java

Hi Rahul,     Fix looks good.     But I think the file GenerateTestImage.java should be omitted from patch as it does not have any fix related change.   Regards, Ambarish       From: Rahul Singh Sent: Friday, January 06, 2017 11:22 AM To: