Re: [9] Review request for JDK-7119774: [macosx] test ComponentMousePositionTest sometimes fail on Mac

2017-02-14 Thread Ambarish Rapte
Hi Manajit, Please include the jtreg tag: @key headful & also include the bug id: 4009555 from the original test. Regards, Ambarish From: Sergey Bylokhov Sent: Monday, February 13, 2017 11:02 PM To: Manajit Halder Cc: awt-dev@openjdk.java.net Subject: Re: [9] Review request for JDK-7119

Re: AWT Dev> [9] Review request for 8163979: [macosx] Chinese text shows as Latin w/ openVanilla input method

2017-02-14 Thread Sergey Bylokhov
Looks fine. > > Thank you, Phil. I have updated the fix based on your suggestion. Please find > the new version here: http://cr.openjdk.java.net/~dmarkov/8163979/webrev.03/ > > > Thanks, > Dmitry >> On 14 Feb 2017, at 01:54, Phil Race >

[9] Review Request: 8033128 Javadoc change is required for java.awt.Robot(GraphicsDevice screen) constructor

2017-02-14 Thread Sergey Bylokhov
Hello, Please review the fix for jdk9. In the fix the «getPixelColor» is added to the list of methods which affected by this constructor. Also the notion «This constructor is meant for the latter case» is removed, because irrespective of platform configuration the coordinates passed to Robot met

Re: [9] Review request for JDK-7119774: [macosx] test ComponentMousePositionTest sometimes fail on Mac

2017-02-14 Thread Manajit Halder
Hi All, Thanks for your review comments. Please review the modified code. http://cr.openjdk.java.net/~mhalder/7119774/webrev.02/ Thanks, Manajit > On 14-Feb-2017, at 2:14 pm, Ambarish Rapte wrote: > > Hi Manajit, > Please include the jt

Re: [9] Review Request: 8033128 Javadoc change is required for java.awt.Robot(GraphicsDevice screen) constructor

2017-02-14 Thread Alexander Zvegintsev
+1 Thanks, Alexander. On 14/02/2017 15:24, Sergey Bylokhov wrote: Hello, Please review the fix for jdk9. In the fix the «getPixelColor» is added to the list of methods which affected by this constructor. Also the notion «This constructor is meant for the latter case» is removed, because ir