Re: java.desktop modularization

2017-03-02 Thread Hontvári Attila
(cc-ing awt-dev) I made a prototype, where java.desktop is split into 16+1 modules. java.swing is the largest module, its size is 6.9 MB, less than the one third of original java.desktop's size (23.3 MB). The prototype compiles without errors, but there are many runtime errors. If there is int

Re: [9] Review request for 8176097 Window set location to a display with different DPI does not properly work

2017-03-02 Thread Sergey Bylokhov
Hi, Alex. Looks like after the fix the fields in sysX/Y and sysW/sysH will have incompatible values, the location will use the one screen to scale and the size will use another, Is it possible to store the location+size based on same screen? > > Hello, > > Could you review the fix: > bug: ht

Re: [9] Review request for 8173853: IllegalArgumentException in java.awt.image.ReplicateScaleFilter

2017-03-02 Thread Sergey Bylokhov
Hi, Dmitry. I have only the one question: the size 0,0 can be returned if the custom cursors are not supported. I wonder should our CustomCursor have an initial size, of it should have zero size? > Hello, > > Could you review a fix for jdk9, please? > > bug: https://bugs.openjdk.java.net

[9] Review request for 8173853: IllegalArgumentException in java.awt.image.ReplicateScaleFilter

2017-03-02 Thread dmitry markov
Hello, Could you review a fix for jdk9, please? bug: https://bugs.openjdk.java.net/browse/JDK-8173853 webrev: http://cr.openjdk.java.net/~dmarkov/8173853/webrev.00/ Problem description: Sometimes XQueryBestCursor may return zero-dimension to the code inside XCustomCursor.getBes

Re: [JDK-8048731] com.apple.eawt.FullScreenUtilities#setWindowCanFullScreen

2017-03-02 Thread Reto Merz
Hello Alexander, Thanks for clarifying that. Regards Reto On 02.03.2017 16:26, Alexander Zvegintsev wrote: Hello, there is no replacement for setWindowCanFullScreen(), resizable windows are made fullscreenable by default(JDK-8143914). However there is unofficial way to override it: jFrame.

[9] Review request for 8176097 Window set location to a display with different DPI does not properly work

2017-03-02 Thread Alexandr Scherbatiy
Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8176097 webrev: http://cr.openjdk.java.net/~alexsch/8176097/webrev.00 Suppose the system has two displays with different DPI. A user can create a window on the first screen and set the windows bounds from t

Re: [JDK-8048731] com.apple.eawt.FullScreenUtilities#setWindowCanFullScreen

2017-03-02 Thread Alexander Zvegintsev
Hello, there is no replacement for setWindowCanFullScreen(), resizable windows are made fullscreenable by default(JDK-8143914 ). However there is unofficial way to override it: jFrame.getRootPane().putClientProperty("apple.awt.fullscreenable"

Re: [9] Review Request: 8168307 Toolkit.getScreenSize() returns incorrect size on unix in multiscreen systems

2017-03-02 Thread Alexander Zvegintsev
+1 -- Thanks, Alexander. On 02.03.2017 12:11, Alexandr Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 2/28/2017 8:21 PM, Sergey Bylokhov wrote: Hi, Alexander. The XToolkit.getDefaultScreenWidth()/getDefaultScreenHeight() methods are supposed to return the width/height in

[JDK-8048731] com.apple.eawt.FullScreenUtilities#setWindowCanFullScreen

2017-03-02 Thread Reto Merz
Hi, Is there a replacement for com.apple.eawt.FullScreenUtilities#setWindowCanFullScreen(Window, Boolean) in Java 9 Desktop API? I can not find a similar method on java.awt.Desktop, java.awt.Taskbar or javax.swing.JFrame class. Thanks Reto

Re: [9] Review Request: 8176009 The awt robot use incorrect location in a multi-screen environment

2017-03-02 Thread Alexandr Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 3/1/2017 4:51 PM, Alexander Zvegintsev wrote: +1 -- Thanks, Alexander. On 01.03.2017 12:55, Sergey Bylokhov wrote: Hello, Please review the fix for jdk9. The fix reverts the changes which were introduced in JDK-8145784(the test SpuriousMouseEv

Re: [9] Review Request: 8168307 Toolkit.getScreenSize() returns incorrect size on unix in multiscreen systems

2017-03-02 Thread Alexandr Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 2/28/2017 8:21 PM, Sergey Bylokhov wrote: Hi, Alexander. The XToolkit.getDefaultScreenWidth()/getDefaultScreenHeight() methods are supposed to return the width/height in the user space. Could you rename them and the screenWidth/screenHeight vari