Re: [10] Review request for 8177414: Missing key events on Mac Os

Looks fine. On 02.08.2017 7:26, Dmitry Markov wrote: Hello, Could you review a fix for jdk10, please? bug: https://bugs.openjdk.java.net/browse/JDK-8177414 webrev: http://cr.openjdk.java.net/~dmarkov/8177414/webrev.00/ Problem description: On OSX KEY_TYPED and KEY_PRESSED events

Re: [10] Review request for JDK-8136999: [macosx] NSException and NPE in a crash test

Looks fine. On 03.08.2017 6:27, Manajit Halder wrote: Hi Sergey, Added the test case from the previous iteration of the fix. Please review the webrev: http://cr.openjdk.java.net/~mhalder/8136999/webrev.01/ Regards, Manajit On 26-Jul-2017, at 10:32 PM, Sergey Bylokhov

Re: [10] Review request for 8178448: MenuBar item handler fired twice

Looks fine. On 02.08.2017 23:28, Alexander Zvegintsev wrote: Hi Sergey, http://cr.openjdk.java.net/~azvegint/jdk/10/8178448/01/ I've updated the test. The JFrame needs to be iconified because it is stealing the keyboard focus, so accelerators for menu items will not be triggered. Thanks,

Re: [10] Review request for JDK-8136999: [macosx] NSException and NPE in a crash test

Hi Sergey, Added the test case from the previous iteration of the fix. Please review the webrev: http://cr.openjdk.java.net/~mhalder/8136999/webrev.01/ Regards, Manajit > On 26-Jul-2017, at 10:32 PM, Sergey Bylokhov

Re: [10] Review request for 8178448: MenuBar item handler fired twice

Hi Sergey, http://cr.openjdk.java.net/~azvegint/jdk/10/8178448/01/ I've updated the test. The JFrame needs to be iconified because it is stealing the keyboard focus, so accelerators for menu items will not be triggered. Thanks, Alexander. On 02/08/2017 21:12, Sergey Bylokhov wrote: Hi,