On 9/15/17 17:04, semyon.sadet...@oracle.com wrote:
test/java/awt/ComponentOrientation/WindowTest should test the window
orientation. So, it should call applyComponentOrientation().
ResourceBundle should be tested somewhere else.
It is fine because it tests the ComponentOrientation class which
test/java/awt/ComponentOrientation/WindowTest should test the window
orientation. So, it should call applyComponentOrientation().
ResourceBundle should be tested somewhere else.
On 9/15/17 4:53 PM, Sergey Bylokhov wrote:
I guess you missed something, the possibility to configure the
component
I guess you missed something, the possibility to configure the
components via ResourceBudnle or locale is something different that the
hardcore the orientation in the application. And the fact that this test
found the bug in jdk9 just show that the test is valid.
On 9/15/17 16:29, Semyon Sadet
The component orientation test suite should use the right API, not the
deprecated one. This was missed when the new API is created.
So the change is valid from this point with the corresponding comment in
JIRA.
--Semyon
On 9/15/2017 3:09 PM, Sergey Bylokhov wrote:
On 9/14/17 23:15, Pankaj Ba
On 9/14/17 23:15, Pankaj Bansal wrote:
This test is not failing with JDK 9_181 and JDK10 as methods are deprecated not
removed. It is giving lot of warning for using deprecated things, so I made
these changes. I think the bug description should be changed to notify that.
I am not sure that i
It is broken from the moment when it was implemented(I have rechecked on
8u121 which was mentioned in the report), unlike Apple jdk where it worked.
On 9/15/17 08:55, Semyon Sadetsky wrote:
Hi Sergey,
what was caused the regression?
--Semyon
On 9/14/2017 3:46 PM, Sergey Bylokhov wrote:
Hell
Hi Sergey,
what was caused the regression?
--Semyon
On 9/14/2017 3:46 PM, Sergey Bylokhov wrote:
Hello,
Please review the fix for jdk10.
Bug: https://bugs.openjdk.java.net/browse/JDK-8186559
Webrev can be found at:
http://cr.openjdk.java.net/~serb/8186559/webrev.00
When our NSView is embed
Hi Sergey,
The fix looks good to me.
Thanks,
Dmitry
> On 14 Sep 2017, at 23:46, Sergey Bylokhov wrote:
>
> Hello,
> Please review the fix for jdk10.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8186559
> Webrev can be found at: http://cr.openjdk.java.net/~serb/8186559/webrev.00
>
> When
