Re: [10] RFR JDK-8088132:[Swing, singleThread] ClassCastException in nested event loop when showing multiple message dialogs in SwingNode

2017-09-19 Thread Prasanta Sadhukhan
Hi Sergey, On 9/18/2017 11:57 PM, Sergey Bylokhov wrote: Hi, Prasanta.  - In this version it is unclear what is a purpose of the "fxCheckSequenceThread.start()". This code will start the thread and will continue execution, it will not wait when the thread will stop.  - The DefaultKeyboardFocu

Re: [10] JDK-8178361: JFileChooser does not allow to open folders with a double tap when using the touch screen interface

2017-09-19 Thread Shashidhara Veerabhadraiah
Anton, I do not agree to your comments. I am implementing a different message to enable the touch functionality compared to your software changes. There is only a copy of the win8orlater variable because this is required for my api's too!! Rest all those changes have to be laid in a similar way

Re: [10] Review Request: JDK-8081311 : [TEST_BUG] java/awt/ComponentOrientation/WindowTest.java

2017-09-19 Thread Semyon Sadetsky
On 09/18/2017 11:04 AM, Sergey Bylokhov wrote: On 9/18/17 10:14, Semyon Sadetsky wrote: It is fine because it tests the ComponentOrientation class which is loaded from the resource bundle and applied to the window. I would agree with you if the resource bundle at least contained a value for th

Re: [10] Review Request: 8178274 Java_sun_lwawt_macosx_NSEvent_nsToJavaKeyInfo() overreads jchar variable

2017-09-19 Thread Semyon Sadetsky
+1 Please, add the corresponding noreg label to the bug. --Semyon On 09/18/2017 01:12 PM, Sergey Bylokhov wrote: Hello, Please review the fix for jdk10. Bug: https://bugs.openjdk.java.net/browse/JDK-8178274 Webrev can be found at: http://cr.openjdk.java.net/~serb/8178274/webrev.00 We pass

Re: [10] JDK-8178361: JFileChooser does not allow to open folders with a double tap when using the touch screen interface

2017-09-19 Thread Anton Litvinov
Good day Shashidhara, You took parts of my fix for the bug (https://bugs.openjdk.java.net/browse/JDK-8166772) which is being reviewed on this e-mail alias since 17/08/2017 and which is almost approved by one reviewer (http://mail.openjdk.java.net/pipermail/awt-dev/2017-September/012999.html).