+1
Thanks,
Alexander.
On 22/09/2017 06:09, Anton Litvinov wrote:
Hello Sergey,
Thank you very much for review of this fix. The second version of the
fix with minor changes in 3 places which address your remarks is
created. The new fix version applied to the today's version of the
consolidat
Hi Shashi,
I am also reviewing your fix since last week. I built "jdk10/client"
with your fix and was able to see, how the 1st and the 2nd versions of
your fix work. I have the following remarks and questions to you:
1. The fix causes a rather significant regression, which is a loss of
the d
On 9/25/17 11:49, Anton Litvinov wrote:
Hello Sergey,
Thank you for approval of the fix. Yes, sure, I will file a CSR. Do you
suggest to file a CSR about the new property
"awt.touchKeyboardAutoShowIsEnabled" or the whole functionality
implemented in this fix, particularly - support of automat
Hi Dmitry,
On 09/25/2017 01:09 PM, Dmitry Markov wrote:
Hi Semyon,
This issue and the problem addressed by 8139218 and 8159432 are slightly
different. This one is still reproducible on latest 9 and 10 builds using the
test case attached to the bug or regression test provided with the fix.
I
On 9/22/17 04:22, Alexey Ivanov wrote:
There's no way of knowing in advance.
Explorer does not restrict the size of icons (now), it's up to
developers of a particular file handler to provide icons. Usually,
there's only one icon with size larger than 255.
If there's the icon of the requested
Hi Alexander,
Sounds reasonable. I am OK with usage of addChildWindow() in this case.
Thanks,
Dmitry
> On 25 Sep 2017, at 13:05, Alexander Zvegintsev
> wrote:
>
> Hi Dmitry,
>
> From my understanding JavaFX stage can't be easily integrated in JDK to
> support orderWindow() approach,
>
> add
Hi Semyon,
This issue and the problem addressed by 8139218 and 8159432 are slightly
different. This one is still reproducible on latest 9 and 10 builds using the
test case attached to the bug or regression test provided with the fix.
The problem takes place when we restore focus to a component
Hello Sergey,
Thank you for approval of the fix. Yes, sure, I will file a CSR. Do you
suggest to file a CSR about the new property
"awt.touchKeyboardAutoShowIsEnabled" or the whole functionality
implemented in this fix, particularly - support of automatic showing of
the touch keyboard without
Looks fine.
On 9/21/17 17:39, Anton Litvinov wrote:
Could you please answer my question.
- Should CCC request be filed for the new system property
"awt.touchKeyboardAutoShowIsEnable", whose value is considered as "true"
by default, if it is not specified by the user explicitly while
launching
From the AWT point of view the fix looks fine.
On 9/23/17 00:03, Prasanta Sadhukhan wrote:
Hi Sergey,
Please find modified webrev catering to DefaultKeyboardFocusManager also
http://cr.openjdk.java.net/~psadhukhan/8088132/webrev.05/
Regards
Prasanta
On 9/23/2017 7:52 AM, Sergey Bylokhov wrote:
Looks fine.
On 9/23/17 08:25, Dmitry Markov wrote:
Hello,
Could you review a fix for jdk10, please?
bug: https://bugs.openjdk.java.net/browse/JDK-8155197
webrev: http://cr.openjdk.java.net/~dmarkov/8155197/webrev.00/
Problem description:
Currently we restore focus synchronously to a com
Hi Alexander,
On the Windows platform you've only modified the dialog native peer
while on other platforms all window types are modified to use FX window
as a parent. Shouldn't the frame native peer be modified too on the
Windows platform?
--Semyon
On 09/21/2017 10:56 PM, Alexander Zvegin
Hi Dmitry,
This issue was already fixed in 9. See 8139218 & 8159432.
--Semyon
On 09/23/2017 08:25 AM, Dmitry Markov wrote:
Hello,
Could you review a fix for jdk10, please?
bug: https://bugs.openjdk.java.net/browse/JDK-8155197
webrev: http://cr.openjdk.java.net/~dmarkov/8155197/webrev.
Hi Sergey,
Thanks for catching this, this is an issue which should be addressed.
Thanks,
Alexander.
On 23/09/2017 08:01, Sergey Bylokhov wrote:
Hi, Alexander.
How can we be sure that the parent frame will not be disposed while we
use a pointer?
long ownerWindowPtr = peer.getOverridenWindowH
Hi Dmitry,
From my understanding JavaFX stage can't be easily integrated in JDK to
support orderWindow() approach,
addChildWindow() is a native(and the simplest) way to maintain one
window above other one, should be called only once.
IIUC the main concert of JDK-8080729 that child windows j
Hi Shashi,
On 25/09/2017 06:59, Shashidhara Veerabhadraiah wrote:
RE: [10] JDK-8178361: JFileChooser does not allow to open
folders with a double tap when using the touch screen interface
Hi Alexey, Please see below for my replies:
<<...>> <<...>> <<...>>
Thanks and regards,
Shashi
-
16 matches
Mail list logo
