Re: [10] Review Request: 8182410, 8183508, 8181289

2017-10-24 Thread Sergey Bylokhov
On 24/10/2017 14:56, Semyon Sadetsky wrote: On 10/24/2017 12:02 PM, Sergey Bylokhov wrote: Hi, Semyon I guess I did not add a new tags, it seems that this tag is used as an anchor everywhere and since it is allowed in html5 its usage was preserved. Starting version 9 JDK supports the html5 m

Re: [10] Review Request: 8182410, 8183508, 8181289

2017-10-24 Thread Jonathan Gibbons
Semyon, Although id is a global attribute and can be used to identify any node, some browsers do better navigation/scrolling when the id is in an tag. We have seen poor autoscrolling behavior when the id is an a header tag, such that the header ends up obscured under the navigation bar at

Re: [10] Review Request: 8182410, 8183508, 8181289

2017-10-24 Thread Semyon Sadetsky
On 10/24/2017 12:02 PM, Sergey Bylokhov wrote: Hi, Semyon I guess I did not add a new tags, it seems that this tag is used as an anchor everywhere and since it is allowed in html5 its usage was preserved. Starting version 9 JDK supports the html5 markup in javadoc, so the files need to be up

Re: [10] Review Request: JDK-8159062 : [hidpi] DnD on Windows while scaling is non-integer

2017-10-24 Thread Sergey Bylokhov
Hi, Pankaj. Please provide a test case for the issue. On 24/10/2017 02:43, Pankaj Bansal wrote: Hi All, Please review the fix for JDK 10. Bug: https://bugs.openjdk.java.net/browse/JDK-8159062 Webrev: http://cr.openjdk.java.net/~psadhukhan/pankaj/JDK-8159062-webrev.00/ Issue: There are iss

Re: [10] Review Request: 8182410, 8183508, 8181289

2017-10-24 Thread Sergey Bylokhov
Hi, Semyon I guess I did not add a new tags, it seems that this tag is used as an anchor everywhere and since it is allowed in html5 its usage was preserved. On 23/10/2017 22:08, Semyon Sadetsky wrote: Hi Sergey, I see no reason to have an extra empty anchor tag to set a bookmark. The id a

Re: [10] Review request for 8182043: Access to Windows Large Icons

2017-10-24 Thread Alexey Ivanov
Hi Sergey, On 24/10/2017 00:22, Sergey Bylokhov wrote: On 17/10/2017 09:42, Alexey Ivanov wrote: This is my understanding, before those fix the maximum size was 32x32. It is my understanding too. Thus limiting the size of icon to 128 pixels seemed reasonable. At this moment the buffer for

[10] Review Request: JDK-8159062 : [hidpi] DnD on Windows while scaling is non-integer

2017-10-24 Thread Pankaj Bansal
Hi All, Please review the fix for JDK 10. Bug: https://bugs.openjdk.java.net/browse/JDK-8159062 Webrev: http://cr.openjdk.java.net/~psadhukhan/pankaj/JDK-8159062-webrev.00/ Issue: There are issue with the mouse move events when HIDPI scale is set to some non-integer value like