Re: [10] Review request for 8183504: 8u131 Win 10, issue with wrong position of Sogou IME popup

2017-10-25 Thread Prasanta Sadhukhan
Hi Semyon, It now works for windows10 but regress in windows 7 for me, where no Sogou input window appears below text component. Regards Prasanta On 10/26/2017 4:52 AM, Semyon Sadetsky wrote: Hi Prasanta, Please try an updated version of the fix http://cr.openjdk.java.net/~ssadetsky/818350

Re: [10] Review Request: 8187639 TrayIcon is not properly supported on macOS in multi-screen environment

2017-10-25 Thread Sergey Bylokhov
On 16/10/2017 12:14, semyon.sadet...@oracle.com wrote: But what to do with compatibility issues? Do you provide any options to run existing applications? The existing applications will use the new functionality which behaves like the old ones. The appearance of the message itself will differ b

Re: [10] Review Request: 8182410, 8183508, 8181289

2017-10-25 Thread Semyon Sadetsky
Hi Jonathan, On 10/24/2017 03:20 PM, Jonathan Gibbons wrote: Semyon, Although id is a global attribute and can be used to identify any node, some browsers do better navigation/scrolling when the id is in an tag.  We have seen poor autoscrolling behavior when the id is an a header tag, suc

Re: [10] Review request for 8189204: Possible NPE in Component::getLocationOnScreen()

2017-10-25 Thread Sergey Bylokhov
Looks fine. On 25/10/2017 17:37, Semyon Sadetsky wrote: Hello, Please review fix for JDK10: bug: https://bugs.openjdk.java.net/browse/JDK-8189204 webrev: http://cr.openjdk.java.net/~ssadetsky/8189204/webrev.00/ The fix eliminates possibility of NPEs in Component ::getLocationOnScreen().  Me

[10] Review request for 8189204: Possible NPE in Component::getLocationOnScreen()

2017-10-25 Thread Semyon Sadetsky
Hello, Please review fix for JDK10: bug: https://bugs.openjdk.java.net/browse/JDK-8189204 webrev: http://cr.openjdk.java.net/~ssadetsky/8189204/webrev.00/ The fix eliminates possibility of NPEs in Component ::getLocationOnScreen().  Method Component ::getLocationOnScreen_NoTreeLock() does no

Re: [10] Review request for 8183504: 8u131 Win 10, issue with wrong position of Sogou IME popup

2017-10-25 Thread Semyon Sadetsky
Hi Prasanta, Please try an updated version of the fix http://cr.openjdk.java.net/~ssadetsky/8183504/webrev.01/ On 10/25/2017 12:36 AM, Prasanta Sadhukhan wrote: Hi Semyon, In windows10 after your fix too, I still find the sogou input appearing at the bottom right corner of the screen, not

Re: java-atk-wrapper accessibility and openjdk9

2017-10-25 Thread mandy chung
Hi Fridrich, The maintainer of java-atk-wrapper was informed of the new javax.accessibility.AccessibilityProvider service interface during JDK 9 development.   java-atk-wrapper will need to implement a provider of AccessibilityProvider to run on JDK 9 [1]. Adding to Phil's comment, java-atk-

Re: java-atk-wrapper accessibility and openjdk9

2017-10-25 Thread Phil Race
I don't think patching ClassLoader files is a good idea and the folks that own ClassLoader are extremely unlikely to endorse anything like it. Have you looked at javax.accessibility.AccessibilityProvider ? It was designed with providers like ATK partly in mind. See https://bugs.openjdk.java.ne

Re: [10] Review Request: JDK-8159062 : [hidpi] DnD on Windows while scaling is non-integer

2017-10-25 Thread Pankaj Bansal
Hi Sergey, I have added a test case and updated the webrev. Please have a look. Webrev http://cr.openjdk.java.net/~arapte/pankaj/8159062/webrev.01/ Regards, Pankaj Bansal -Original Message- From: Sergey Bylokhov Sent: Wednesday, October 25, 2017 1:04 AM To: Pankaj Bansal; awt-dev@openj

java-atk-wrapper accessibility and openjdk9

2017-10-25 Thread Fridrich Strba
Hello, good people, For some time, since openjdk was released, we have used as accessibility provider java-atk-wrapper that wraps around the GNOME accessibility toolkit. The java-atk-wrapper is composed from a jar file java-atk-wrapper.jar and a native library libjava-atk-wrapper.so that the java

Re: [10] Review request for 8183504: 8u131 Win 10, issue with wrong position of Sogou IME popup

2017-10-25 Thread Prasanta Sadhukhan
Hi Semyon, In windows10 after your fix too, I still find the sogou input appearing at the bottom right corner of the screen, not below text component caret. However  in windows 7, even without your fix, I find the sogou input appearing below text component caret. Regards Prasanta On 10/2/20