Looks fine.
On 05/12/2017 23:23, Shashidhara Veerabhadraiah wrote:
Hi All, Please review a fix for the below bug.
Bug: https://bugs.openjdk.java.net/browse/JDK-8190515
Webrev: http://cr.openjdk.java.net/~sveerabhadra/8190515/webrev.00/
Summary: The file delete operation generates pop up dialo
Hi Semyon, Thanks for your review.
Even I had got mixed up between them initiallyJ.
Thank you Sergey for your initial review.
Have a nice day.
Thanks and regards,
Shashi
From: Semyon Sadetsky
Sent: Friday, December 8, 2017 9:20 PM
To: shashidhara veerabhadraiah
Cc: awt-dev@openj
Hi Shashi,
I mixed upGetActionModifiers andGetJavaModifiers. GetActionModifiers shouldn't
contain mouse button mask.
The fix looks good.
--Semyon
On 12/6/17 10:57 AM, shashidhara veerabhadraiah wrote:
Hi Semyon, Sure I understand your concern.
Will update web rev on this and get back to you
Reminder. Could you take look, please?
Also I would like to clarify the purpose of the fallback mechanism introduced
by the new version. The fallback code addresses the issue that users have not
knowing what permission to grant because some connections, (e.g. HTTP) may be
established by grantin