Re: Run AWT on MacOSX with -XstartOnFirstThread

2017-12-18 Thread Sergey Bylokhov
I think it is not possible. The code related to this initialization is located in: open/src/java.desktop/macosx/native/libawt_lwawt/awt/LWCToolkit.m + (void)starter:(BOOL)wasOnMainThread headless:(BOOL)headless { if (forceEmbeddedMode) { AWT_STARTUP_LOG(@"in SWT or

Re: [10] RFR 8193435: Remove pre-1.2 SecurityManager text from java.awt.Toolkit

2017-12-18 Thread Sean Mullan
This looks good to me. The JDK SecurityManager implementation of checkRead and checkConnect have both been changed to call checkPermission since JDK 1.2 so the fallback code is redundant. --Sean On 12/18/17 11:47 AM, Dmitry Markov wrote: Hello, Could you review a fix for jdk10, please?  

Re: [10] RFR 8193435: Remove pre-1.2 SecurityManager text from java.awt.Toolkit

2017-12-18 Thread Phil Race
Dmitry, Did you confirm that there are no tests that check for this removed behaviour ? -phil. On 12/18/2017 10:01 AM, Sergey Bylokhov wrote: Looks fine. On 18/12/2017 08:47, Dmitry Markov wrote: Hello, Could you review a fix for jdk10, please? bug:

Re: RFR - HandleExceptionOnEDT test fix

2017-12-18 Thread Sergey Bylokhov
I think you can use this old bug: https://bugs.openjdk.java.net/browse/JDK-6990210 Please resend a review request using this bugid. On 13/12/2017 22:04, Michal Vala wrote: I don't and I don't have an access to openjdk jira. Can you please create it for me? On 12/13/2017 04:46 PM, Sergey

Re: [10] RFR 8193435: Remove pre-1.2 SecurityManager text from java.awt.Toolkit

2017-12-18 Thread Sergey Bylokhov
Looks fine. On 18/12/2017 08:47, Dmitry Markov wrote: Hello, Could you review a fix for jdk10, please?  bug: https://bugs.openjdk.java.net/browse/JDK-8193435  webrev: http://cr.openjdk.java.net/~dmarkov/8193435/webrev.00/  CSR: https://bugs.openjdk.java.net/browse/JDK-8193709 Problem

[10] RFR 8193435: Remove pre-1.2 SecurityManager text from java.awt.Toolkit

2017-12-18 Thread Dmitry Markov
Hello, Could you review a fix for jdk10, please? bug: https://bugs.openjdk.java.net/browse/JDK-8193435 webrev: http://cr.openjdk.java.net/~dmarkov/8193435/webrev.00/ CSR: https://bugs.openjdk.java.net/browse/JDK-8193709 Problem