Re: [8u-Backport] Review request for 8185634, 8187803 : Java Fx-Swing dialogs appearing behind main stage

2018-01-17 Thread Dipak Kumar
Hi Semyon, Could you please review the changes (also have a look at Phil's comment in trailing mail) and let me know your comments. Thanks Kevin and Phil. I have incorporated the changes suggested for unit tests in JavaFx side. Request you to have a look. Please find updated webrev at - http:

Re: RFR(S): 8194869: [TESTBUG][aix, s390] Adapt tests to platforms.

2018-01-17 Thread Sergey Bylokhov
The client part looks fine. On 17/01/2018 04:43, Lindenmaier, Goetz wrote: Posting this to awt-dev, too. This change adapts some tests to run on properly on aix or s390: http://cr.openjdk.java.net/~goetz/wr18/8194869-jtregAix/webrev.03/ Best regards, Goetz. -Original Message- From

Re: [8u-Backport] Review request for 8185634, 8187803 : Java Fx-Swing dialogs appearing behind main stage

2018-01-17 Thread Kevin Rushforth
I think you mean https://bugs.openjdk.java.net/browse/JDK-8187803 for the AWT/Swing side... -- Kevin Phil Race wrote: The AWT/Swing side of this needs to be bug https://bugs.openjdk.java.net/browse/JDK-8185634 One thing I notice is that in XWindowPeer.java the calculation for the value of

Re: [8u-Backport] Review request for 8185634, 8187803 : Java Fx-Swing dialogs appearing behind main stage

2018-01-17 Thread Kevin Rushforth
Hi Dipak, To underscore the fact that the AWT part of the change has to be pushed under a separate bug ID I have modified the subject line. The FX half of the implementation changes look fine. I tested it on Linux and it works as expected. There are two problems with the unit tests: 1. The

Re: [8u-Backport] Review request for 8185634 : Java Fx-Swing dialogs appearing behind main stage

2018-01-17 Thread Phil Race
The AWT/Swing side of this needs to be bug https://bugs.openjdk.java.net/browse/JDK-8185634 One thing I notice is that in XWindowPeer.java the calculation for the value of transientForWindow is different .. because you don't have the fix for https://bugs.openjdk.java.net/browse/JDK-8021961 : "

Re: [10] JDK-8194135: The content in textArea can not be pasted after clicking "Copy" button.

2018-01-17 Thread Semyon Sadetsky
Hi Shashi,  Why you disabled  HidingSelectionTest.java for Linux platform? How is it related to the TCK test failure? --Semyon On 01/16/2018 10:27 AM, shashidhara veerabhadraiah wrote: Hi Semyon, I ran those tests and found to be passed on the selected platforms. Since in linux platforms,

Re: [10] JDK-8193463: [TESTBUG] [PIT]: java/awt/TrayIcon/TrayIconPopup/TrayIconPopupClickTest.java fails

2018-01-17 Thread Sergey Bylokhov
I am not sure that we need to implement this change in this test, because all our TrayIcon tests which check events use the same approach. Probably we could document it, or mark them by some keyword. On 16/01/2018 22:34, Shashidhara Veerabhadraiah wrote: Hi All, Please review a test only fix fo

Re: RFR JDK-6990210 [TEST_BUG] EventDispatchThread/HandleExceptionOnEDT/HandleExceptionOnEDT.java fails on gnome

2018-01-17 Thread Michal Vala
Thanks, can you please sponsor this? On 01/16/2018 10:55 PM, Sergey Bylokhov wrote: Looks fine. I placed webrev to cr.openjdk: http://cr.openjdk.java.net/~serb/mvala/6990210/webrev.00 On 19/12/2017 02:14, Michal Vala wrote: Hi, sending patch for https://bugs.openjdk.java.net/browse/JDK-699021

Re: RFR(S): 8194869: [TESTBUG][aix, s390] Adapt tests to platforms.

2018-01-17 Thread Lindenmaier, Goetz
Posting this to awt-dev, too. This change adapts some tests to run on properly on aix or s390: http://cr.openjdk.java.net/~goetz/wr18/8194869-jtregAix/webrev.03/ Best regards, Goetz. > -Original Message- > From: David Holmes [mailto:david.hol...@oracle.com] > Sent: Mittwoch, 17. Januar