Hi Semyon, It is not getting decreased for the case of SCROLLBARS_NEVER. The
Boolean flags “needsHorz” and “needsVert” are false for the never case and true
for the other cases. We decrease by the size of the scroll bars only for the
true cases, so in the false case we will use the entire width
On 27/02/2018 07:51, Shashidhara Veerabhadraiah wrote:
Threshold is added because I think it is quite possible especially with
hidpi(fractional) since convert back and forth from user space to device
coordinates which typically results in plus or minus 1 pixel correction(because
of division or
+1
--Semyon
On 02/28/2018 12:13 PM, Dmitry Markov wrote:
Thank you, Sergey!
Looking for the second +1 from someone else.
Thanks in advance,
Dmitry
On 26 Feb 2018, at 22:43, Sergey Bylokhov wrote:
Looks fine.
On 26/02/2018 04:55, Dmitry Markov wrote:
Hello,
Could you review a fix for jd
Thank you, Sergey!
Looking for the second +1 from someone else.
Thanks in advance,
Dmitry
> On 26 Feb 2018, at 22:43, Sergey Bylokhov wrote:
>
> Looks fine.
>
> On 26/02/2018 04:55, Dmitry Markov wrote:
>> Hello,
>> Could you review a fix for jdk11, please?
>> bug: https://bugs.openjdk.java.
My hunt on technical debt continues. This time my aim has been on the
sorry mess known as GensrcX11Wrappers.
I've disentangled it into two functions, one simple gensrc part that is
actually run during the build, and which involves just a simple java
tool and some pre-calculated data files, and
Hi Sashi,
The parent with and height shouldn't be decreased by the size of the
scrollbars in case of SCROLLBARS_NEVER.
--Semyon
On 2/27/2018 12:45 AM, Shashidhara Veerabhadraiah wrote:
Hi Semyon, Thanks for your help. I did some debugging from that
perspective and could find the problem a
Please remove it when push. Util.waitForIdle(r) does all that required.
+1
--Semyon
On 02/28/2018 09:08 AM, Krishna wrote:
Hi Semyon,
I don’t think it is needed, but since it was included in the test, I just
refactored it to a lambda.
Thanks,
Krishna
On 28-Feb-2018, at 10:30 PM, Semyon S
Hi Semyon,
I don’t think it is needed, but since it was included in the test, I just
refactored it to a lambda.
Thanks,
Krishna
> On 28-Feb-2018, at 10:30 PM, Semyon Sadetsky
> wrote:
>
> Hi Krishna,
>
> Does the line
>
> EventQueue.invokeAndWait(() -> { /* Empty */ });
>
> is really nece
Hi Krishna,
Does the line
EventQueue.invokeAndWait(() -> { /* Empty */ });
is really necessary for test to pass?
--Semyon
On 02/27/2018 09:56 AM, Krishna Addepalli wrote:
Hi Sergey/Phil,
Thanks for pointing that out. I have created a new webrev:
http://cr.openjdk.java.net/~kaddepalli/8197
