Re: [11] Review Request: 8201626 Typo in MakeWindowAlwaysOnTop test

+1 -Original Message- From: Sergey Bylokhov Sent: Tuesday, April 17, 2018 6:42 AM To: awt-dev@openjdk.java.net; Krishna Addepalli Subject: [11] Review Request: 8201626 Typo in MakeWindowAlwaysOnTop test Hello. Please review the fix for jdk11. The small typo was fixed. Bug: https://bug

Re: RFR: JDK-8194327 [macos] AWT windows have incorrect main/key window behaviors

Hi Sergey, There is one other factor needed to explain the zombie color panel: The program is leaving behind stale window data, specifically, descriptions of windows that were closed prior to the termination of the program. The cause of this stale data is that AWT does not terminate the NSAppli

[11] Review Request: 8201626 Typo in MakeWindowAlwaysOnTop test

Hello. Please review the fix for jdk11. The small typo was fixed. Bug: https://bugs.openjdk.java.net/browse/JDK-8201626 Fix is inline below: diff test/jdk/java/awt/Dialog/MakeWindowAlwaysOnTop/MakeWindowAlwaysOnTop.java @key headful - @bug 6829546, 8197808 + @bug 6829546 8197808 @summ

Re: [11] Review request for 8199748: Touch keyboard is not shown, if text component gets focus from other text component

Hi, Anton. Maybe this was discussed before, but can you please clarify why we did not show the keyborad on focus_gain? BTW looks like the WTookit.compOnxxx should be a weak references. On 16/04/2018 05:03, Anton Litvinov wrote: Hello, Could you please review the following fix for the bug. B

Re: [11] Review Request: 8200146 Remove the appletviewer launcher

+1 -phil. On 3/30/18, 3:52 PM, Sergey Bylokhov wrote: Hello. Please review fix for jdk11. Bug: https://bugs.openjdk.java.net/browse/JDK-8200146 Webrev can be found at: http://cr.openjdk.java.net/~serb/8200146/webrev.00 CSR: https://bugs.openjdk.java.net/browse/JDK-8200549 Fix description:

Re: [11] Review Request: 8187392 Deprecated methods in the peers can be removed

+1 -phil. On 4/3/18, 11:43 PM, Sergey Bylokhov wrote: Hello. Please review fix for jdk11. Bug: https://bugs.openjdk.java.net/browse/JDK-8187392 Webrev can be found at: http://cr.openjdk.java.net/~serb/8187392/webrev.05 In jdk1.0 era the "java.awt.peer.ComponentPeer" interface had a few met

Re: [11] Review Request: 8199932 Missing copyright header in AWT source code

+1 -phil. On 4/6/18, 5:25 PM, Sergey Bylokhov wrote: Hello. Please review small cleanup for jdk11. Bug: https://bugs.openjdk.java.net/browse/JDK-8199932 Webrev can be found at: http://cr.openjdk.java.net/~serb/8199932/webrev.00 A few places were updated to have correct specification(gpl+cp)

Re: Proposal:AIX's IME support

Hello. Sorry I'm late. Christoph Langer helped me to put webrev file into cr.openjdk.java.net. See, http://cr.openjdk.java.net/~clanger/webrevs/8201429.0/ Actually, he found *.patch files had unexpected entries, I fixed the issue. It seemed that webrev tool could not handle "hg copy" action. I

Re: [11] RFR for JDK-8199627: Use "Per-Monitor V2" High DPI awareness for Windows 10 v1703

Hi Magnus, I haven't found a way to suppress this warning. I tried. There's no way to suppress warnings from mt.exe [1] unfortunately. We're using Visual Studio 2013 to build JDK, the element was added in 2016. Newer versions of Windows SDK should recognise the element. Yes, it works as int

Re: [11] RFR for JDK-8199627: Use "Per-Monitor V2" High DPI awareness for Windows 10 v1703

Hi Alexey, Since this patch, I'm getting lots of warnings on Windows: c:/cygwin64/home/magnusi/hg/sandbox/open/src/java.base/windows/native/launcher/java.manifest : manifest authoring warning 81010002: Unrecognized Element "dpiAwareness" in namespace "http://schemas.microsoft.com/SMI/2016/Win

[11] Review request for 8199748: Touch keyboard is not shown, if text component gets focus from other text component

Hello, Could you please review the following fix for the bug. Bug: https://bugs.openjdk.java.net/browse/JDK-8199748 Webrev: http://cr.openjdk.java.net/~alitvinov/8199748/jdk11/webrev.00 In the fix for JDK-8166772 it was deliberately implemented that the touch keyboard is shown only on "MouseEv