Re: [11] Review Request: JDK-8196616 java/awt/GraphicsDevice/DisplayModes/CompareToXrandrTest.java fails

2018-05-14 Thread Manajit Halder
Looks good to me Regards, Manajit > On 14-May-2018, at 10:38 PM, Phil Race wrote: > > This works on my system. > > +1 > > -phil. > > On 05/10/2018 01:30 PM, Pankaj Bansal wrote: >> Hi Phil, >> >> Thanks for the quick review. >> >> <> takeWhile() which >> <> internal buffer >> <> Buffered

Re: [11] JDK-8169187: [macosx] Aqua: java/awt/image/multiresolution/MultiresolutionIconTest.java

2018-05-14 Thread Sergey Bylokhov
On 13/05/2018 23:55, shashidhara.veerabhadra...@oracle.com wrote: As you can see here, it is possible to have different colors for each sub pixel, but the getPixelColor() will invariably choose only the first pixel color. Then it is unclear why the colors are different for different pixels, s

Re: [11] RFR JDK-8202824: Cleanup discrepancies in ProblemList for java_awt jtreg tests

2018-05-14 Thread Sergey Bylokhov
Looks fine. On 14/05/2018 00:09, Jayathirth D V wrote: Hello All, Please review the following fix in JDK11 : Bug : https://bugs.openjdk.java.net/browse/JDK-8202824 Webrev : http://cr.openjdk.java.net/~jdv/8202824/webrev.00/ _Issue:_ There are some discrepancies in java_awt part of ProblemLis

Re: RFR: JDK-8194327 [macos] AWT windows have incorrect main/key window behaviors

2018-05-14 Thread Alan Snyder
Please review this revised webrev, which contains changes to the test program per Sergey’s comments. Thank you. Alan http://cr.openjdk.java.net/~serb/alans/8194327/webrev.02 https://bugs.openjdk.java.net/browse/JDK-8194327

Re: [11] Review Request: JDK-8196616 java/awt/GraphicsDevice/DisplayModes/CompareToXrandrTest.java fails

2018-05-14 Thread Phil Race
This works on my system. +1 -phil. On 05/10/2018 01:30 PM, Pankaj Bansal wrote: Hi Phil, Thanks for the quick review.

Re: RFR: 8201429: Support AIX Input Method Editor (IME) for AWT Input Method Framework (IMF)

2018-05-14 Thread Ichiroh Takiguchi
Hello Christoph. Our team tested your fixed code on Linux (RHEL7) and AIX (7.1). resetCompositionState() was missing in src/java.desktop/aix/classes/sun/awt/X11InputMethod.java --- a/src/java.desktop/aix/classes/sun/awt/X11InputMetho

[11] RFR JDK-8202824: Cleanup discrepancies in ProblemList for java_awt jtreg tests

2018-05-14 Thread Jayathirth D V
Hello All, Please review the following fix in JDK11 : Bug : https://bugs.openjdk.java.net/browse/JDK-8202824 Webrev : http://cr.openjdk.java.net/~jdv/8202824/webrev.00/ Issue: There are some discrepancies in java_awt part of ProblemList like bud ID typo, invalid bug id. Solution