[11] Review Request: 8203380 Missing platform and bug information for MouseModifiersInKeyEvent test

2018-05-17 Thread Sergey Bylokhov
Hello. Please review small fix for jdk11. Bug: https://bugs.openjdk.java.net/browse/JDK-8203380 There is no bug and platform information for this test in the problem list, but it should point to JDK-8157147 on linux/solaris. Since this test was added to the problem list in JDK-8202811 I assume

Re: [11] Review Request: 8201364 [macosx] Component.getLocation() gives inconsistent coordinate for a component at (0, 0)

2018-05-17 Thread Dmitry Markov
> On 17 May 2018, at 20:04, Sergey Bylokhov wrote: > > On 17/05/2018 11:35, Dmitry Markov wrote: >> So if I got you right, it is not necessary to call these methods if the >> target has been resized. In other words we should NOT change the if-statement >> FROM: >> if (pResized || isNewDevice)

Re: [11] Review Request: 8201364 [macosx] Component.getLocation() gives inconsistent coordinate for a component at (0, 0)

2018-05-17 Thread Sergey Bylokhov
On 17/05/2018 11:35, Dmitry Markov wrote: So if I got you right, it is not necessary to call these methods if the target has been resized. In other words we should NOT change the if-statement FROM: if (pResized || isNewDevice) TO: if (pResized || *tResized *|| isNewDevice) Is my understanding c

Re: [11] Review Request: 8201364 [macosx] Component.getLocation() gives inconsistent coordinate for a component at (0, 0)

2018-05-17 Thread Dmitry Markov
> On 17 May 2018, at 19:25, Sergey Bylokhov wrote: > > On 17/05/2018 02:05, Dmitry Markov wrote: >> Hi Sergey, >> According to your fix replacSurfaceData() and updateMinimumSize() are >> invoked only if the graphics device has been changed or the peer has been >> resized: >>> 734 if

Re: [11] Review Request: 8201364 [macosx] Component.getLocation() gives inconsistent coordinate for a component at (0, 0)

2018-05-17 Thread Sergey Bylokhov
On 17/05/2018 02:05, Dmitry Markov wrote: Hi Sergey, According to your fix replacSurfaceData() and updateMinimumSize() are invoked only if the graphics device has been changed or the peer has been resized: 734 if (pResized || isNewDevice) { 735 replaceSurfaceData();

Re: Proposal:AIX's CDE/MWM support

2018-05-17 Thread Phil Race
I think we'd need to see the actual proposed changes and understand the implications for ongoing support as we no longer support any platform which has a CDE desktop. Solaris 11.3 uses Gnome, so we'd be more inclined to be ripping out such support rather than adding to it. -phil. On 05/17/201

Proposal:AIX's CDE/MWM support

2018-05-17 Thread Ichiroh Takiguchi
Hello, IBM would like to contribute AIX's CDE (Common Desktop Environment) DTWM (Desktop Window Manager) /MWM (Motif Window Manager) support to OpenJDK project. I'd like contribute following 5 files: M src/java.desktop/share/classes/sun/font/FontUtilities.java (Add isAIX flag to determine AIX

Re: [11] Review Request: 8201364 [macosx] Component.getLocation() gives inconsistent coordinate for a component at (0, 0)

2018-05-17 Thread Dmitry Markov
Hi Sergey, According to your fix replacSurfaceData() and updateMinimumSize() are invoked only if the graphics device has been changed or the peer has been resized: > 734 if (pResized || isNewDevice) { > 735 replaceSurfaceData(); > 736 updateMinimumSize(); > 73