Re: Proposal:X11 default visual support for IM status window on VNC

2018-06-19 Thread Naoto Sato
Please change the comment in line 680, which should also mention 13 point font. Naoto On 6/19/18 12:54 PM, Naoto Sato wrote: Looks OK wrt awt_InputMethod.c change. Naoto On 6/19/18 11:32 AM, Phil Race wrote: Where's the bug ID ? The review should have a bug ID in the subject line so we can

Re: Proposal:X11 default visual support for IM status window on VNC

2018-06-19 Thread Naoto Sato
Looks OK wrt awt_InputMethod.c change. Naoto On 6/19/18 11:32 AM, Phil Race wrote: Where's the bug ID ? The review should have a bug ID in the subject line so we can all find it later ! Is this changing the default visual  for all WIndows, not just the IM status window? I think we need to

Re: [11] Review Request: 8205324 Part of java.awt.Desktop.browse(URI) spec is outdated after support of applets was removed

2018-06-19 Thread Sergey Bylokhov
On 19/06/2018 11:05, Phil Race wrote: This is a problem in our current implementation+spec, because the applet api still exists and the method in question should call showDocument() from AppletContext which is returned by "Applet.getAppletContext()" as specified, the problem is that it is neve

Re: Proposal:X11 default visual support for IM status window on VNC

2018-06-19 Thread Phil Race
Where's the bug ID ? The review should have a bug ID in the subject line so we can all find it later ! Is this changing the default visual for all WIndows, not just the IM status window? I think we need to understand the implications before this can be accepted. Similarly for the fontset c

Re: Proposal:X11 default visual support for IM status window on VNC

2018-06-19 Thread Sergey Bylokhov
Looks fine, if there are no other comments I'll push the fix using the new bugid. On 06/06/2018 17:54, Ichiroh Takiguchi wrote: Hello Sergey. Thank you for your review. Could you review following patch ? http://cr.openjdk.java.net/~aleonard/defvis/webrev.01/ Thanks, Ichiroh Takiguchi IBM Japa

Re: [11] Review Request: 8205324 Part of java.awt.Desktop.browse(URI) spec is outdated after support of applets was removed

2018-06-19 Thread Phil Race
On 06/19/2018 11:04 AM, Sergey Bylokhov wrote: This is a problem in our current implementation+spec, because the applet api still exists and the method in question should call showDocument() from AppletContext which is returned by "Applet.getAppletContext()" as specified, the problem is that

Re: [11] Review Request: 8205324 Part of java.awt.Desktop.browse(URI) spec is outdated after support of applets was removed

2018-06-19 Thread Sergey Bylokhov
This is a problem in our current implementation+spec, because the applet api still exists and the method in question should call showDocument() from AppletContext which is returned by "Applet.getAppletContext()" as specified, the problem is that it is never called so we does not follow our spec

Re: [11] Review Request: 8205324 Part of java.awt.Desktop.browse(URI) spec is outdated after support of applets was removed

2018-06-19 Thread Phil Race
I am not sure about some parts of this. The applet API exists and may be implemented by application level code and so whilst the parts that relate to the browser and webstart may not apply, the part that says call AppletContext.showDocument() may still apply. What the application level code

[11] Review Request: 8205324 Part of java.awt.Desktop.browse(URI) spec is outdated after support of applets was removed

2018-06-19 Thread Sergey Bylokhov
Hello. Please review the fix for jdk11. Bug: https://bugs.openjdk.java.net/browse/JDK-8205324 Webrev: http://cr.openjdk.java.net/~serb/8205324/webrev.00 CSR: https://bugs.openjdk.java.net/browse/JDK-8205355 This fix is a part of the effort to drop support of applets/webstart. This change will d

Proposal: DnD cursor is too big on AIX

2018-06-19 Thread Ichiroh Takiguchi
Hello, IBM would like to contribute a patch to OpenJDK project. DnD cursor is too big on IBM AIX. Although XQueryBestCursor() returns 64x64 dots in the environment, 32x32 dots are preferred. I'd like to obtain a sponsor for this patch. --- old/src/java.desktop/unix/classes/sun/awt/X11

Proposal: X11 Time stamp data should be unsigned

2018-06-19 Thread Ichiroh Takiguchi
Hello, IBM would like to contribute a patch to OpenJDK project. Time stamp data on X11 ClientMessage should be 32 bit unsigned int. But it's converted to signed long on Java. It should be masked as unsigned 32bit data I'd like to obtain a sponsor. -- --- old/src/java.desktop/unix/class

Proposal: getGTKIcon with Unicode chars got StringIndexOutOfBoundsException

2018-06-19 Thread Ichiroh Takiguchi
Hello, IBM would like to contribute a patch to OpenJDK project. If a parameter of getGTKIcon contains multi-byte UTF-8 characters, StringIndexOutOfBoundsException may occur. The calculation of string length is confused. We should tell UTF-8’s length and java.lang.String’s length. Candidate fix i

Proposal: Input Method switch popup menu patch

2018-06-19 Thread Ichiroh Takiguchi
Hello, IBM would like to contribute Input Method (IM) switch popup menu patch to OpenJDK project. Issue: Please try following steps to recreate the issue Prerequisite: Download CityIM.jar [1] and InputMethodHotKey.jar [2] Run InputMethodHotKey.jar to set IM hotkey, like $ java -jar InputMethodH