RFR: 8205646: Broken link in jdk.jsobject

2018-07-05 Thread Phil Race
A simple doc bug caused by javadoc now requiring uses of docRoot to include the module. bug : https://bugs.openjdk.java.net/browse/JDK-8205646 Fix : diff --git a/src/jdk.jsobject/share/classes/netscape/javascript/JSObject.java

Re: [11] Review Request: 8201611 Broken links in java.desktop javadoc

2018-07-05 Thread Phil Race
Actually .. I've found that Component.java uses a relative link for doc-files in all other cases. I think that you should actually just remove the usage of @docRoot to make it consistent. It is more logical for this case. -phil. On 07/02/2018 10:16 AM, Phil Race wrote: OK, +1 -phil. On

Re: [12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms.

2018-07-05 Thread Sergey Bylokhov
Hi, Krishna If I read the code in LWChoicePeer.java file correctly, then you can fix the problem by dropping the method below in JComboBoxDelegate class: /** * We should post ITEM_STATE_CHANGED event when the same element is * reselected. */ @Override