8209520: Build fails when native code coverage is enabled

2018-08-23 Thread Leonid Mesnik
Hi Could you please review following fix which fix code so gcc doesn't complain when JDK is build with enabled native code coverage. webrev: http://cr.openjdk.java.net/~lmesnik/8209520/webrev.00/ bug: https://bugs.openjdk.java.net/browse/

Re: 8209520: Build fails when native code coverage is enabled

2018-08-23 Thread Igor Ignatev
Hi Leonid, We have never supported native code coverage builds with warnings enabled as errors. There are bugs in gcc which cause false positive warnings, so it was decided to ignore all warnings from instrumented builds. It’d be much better and reliable to fix makefiles to always use ‘disable-

Re: [12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms.

2018-08-23 Thread Sergey Bylokhov
Hi, Krishna. On 20/08/2018 04:30, Krishna Addepalli wrote: Yes, the behavior is not because of the fix I made. I was trying to understand the implications of the index based selection approach, and now it looks to be consistent on all the platforms. On Mac, as per your suggestion, we can get th

Re: 8209520: Build fails when native code coverage is enabled

2018-08-23 Thread Vladimir Kozlov
macroassembler changes are good. Thanks, Vladimir On 8/23/18 1:51 PM, Leonid Mesnik wrote: Hi Could you please review following fix which fix code so gcc doesn't complain when JDK is build with enabled native code coverage. webrev: http://cr.openjdk.java.net/~lmesnik/8209520/webrev.00/