Re: [8u-backport] JDK 8145547: [AWT/Swing] Conditional support for GTK 3 on Linux

2018-09-12 Thread Kevin Rushforth
Looks fine. Btw, you have a trailing whitespace in gtk2_interface.c that you need to fix before you push (jcheck will tell you about that). -- Kevin On 9/12/2018 5:29 AM, Pankaj Bansal wrote: Hi, I have found a small mistake in gtk_interface.c. I had used wrong name of gtk3 lib at line 56.

Re: [8u-backport] JDK 8145547: [AWT/Swing] Conditional support for GTK 3 on Linux

2018-09-12 Thread Pankaj Bansal
Hi, I have found a small mistake in gtk_interface.c. I had used wrong name of gtk3 lib at line 56. I have correct the same in webrev.02. It is just a typo and should not have any effect on functionality. All should work the same as 01 version. Webrev: http://cr.openjdk.java.net/~pbansal/gtk3

Re: [12] Review Request: 8170937 Swing apps are slow if displaying from a remote source to many local displays

2018-09-12 Thread Alexey Ivanov
Still looks fine. -- Alexey On 12/09/2018 00:08, Philip Race wrote: OK ! -phil. On 9/11/18, 2:54 PM, Sergey Bylokhov wrote: Hi, Phil and Alexey. Thank you for review. For the record the latest version: http://cr.openjdk.java.net/~serb/8170937/webrev.03 On 11/09/2018 12:16, Alexey Ivanov wr