Re: RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled

I guess that it is a good thing to use nullptr, but I think it is better to follow the style used in the file, and replace NULL to nullptr in the whole file in some separate fix. On 14/09/2018 05:18, Prasanta Sadhukhan wrote: one question: why nullptr is used? I see we used NULL in other places

Re: RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled

Hi, Krishna. The "Java Access Bridge" as a product includes WindowsAccessBridge-xx.dll and JavaAccessBridge-xx.dll. On 17/09/2018 14:43, Krishna Addepalli wrote: Hi Sergey, Since the bug was about supporting Java Access Bridge Debugging, I have enabled logging only for Java Access Bridge. So

Re: RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled

Hi Sergey, Since the bug was about supporting Java Access Bridge Debugging, I have enabled logging only for Java Access Bridge. So, any log statements form Windows Access bridge are ignored. Do you think we should enable logging for Windows Access Bridge as well? Thanks, Krishna > On 17-Sep-2

Re: RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled

Hi, Krishna. Can you please recheck how this logging will work when jab code will print something in parallel. As far as I understand libwindowsaccessbridge is loaded by the JAWS and libjavaaccessbridge by java, is it possibly that the log file will be garbled because of two libraries will pri

Re: [12] RFR JDK-8191178:[macos] Problem with input of yen symbol

Hi Dmitry, I guess fullwidth currency symbols are U+FF04 FULLWIDTH DOLLAR SIGN U+FFE1 FULLWIDTH POUND SIGN U+FFE5

Re: [12] RFR JDK-8191178:[macos] Problem with input of yen symbol

Hi Prasanta, I think it would be wise to generate InputMethodEvent for ‘Fullwidth currency symbols’, as well. Thanks, Dmitry > On 17 Sep 2018, at 10:02, Prasanta Sadhukhan > wrote: > > Hi All, > > Please review a fix for an issue where > when "yen" symbol is entered from a keyboard using R

Re: [12] Review Request: 8210692 The "com.sun.awt.SecurityWarning" class can be dropped

On 9/16/18 12:48 AM, Alan Bateman wrote: On 15/09/2018 22:00, Philip Race wrote: It was exported  in the past .. and it was publicly documented .. http://www.oracle.com/technetwork/articles/javase/appletwarning-135102.html .. so I think Sergey was correct in his "JDK" scope. Implementatio

[12] RFR JDK-8191178:[macos] Problem with input of yen symbol

Hi All, Please review a fix for an issue where when "yen" symbol is entered from a keyboard using Romaji keyboard layout using "backslash" character, it was showing a "backslash" character rather than "yen" symbol. This is a regression of JDK-8068283