Re: RFR : 8211317: avoid memory leak in Java_sun_awt_UNIXToolkit_load_1stock_1icon

Hi Matthias, good catch, thanks for fixing this. Looks good. Best regards, Goetz. From: Baesken, Matthias Sent: Donnerstag, 4. Oktober 2018 08:45 To: awt-dev@openjdk.java.net Cc: Lindenmaier, Goetz ; Langer, Christoph Subject: RE: RFR : 8211317: avoid memory leak in Java_sun_awt_UNIXToolki

Re: RFR : 8211317: avoid memory leak in Java_sun_awt_UNIXToolkit_load_1stock_1icon

Thanks Goetz ! As far as I know a second review is needed before pushing – waiting for the second review 😉 … From: Lindenmaier, Goetz Sent: Donnerstag, 4. Oktober 2018 09:04 To: Baesken, Matthias ; awt-dev@openjdk.java.net Cc: Langer, Christoph Subject: RE: RFR : 8211317: avoid memory leak i

Re: [12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms.

Hi Sergey, I had to update the test, since on Mac, it is always selecting the second element, and the test fails. Thanks, Krishna -Original Message- From: Sergey Bylokhov Sent: Monday, October 1, 2018 7:57 AM To: Krishna Addepalli Cc: Ajit Ghaisas ; Shashidhara Veerabhadraiah ; awt-d

Re: [12] Review request for JDK-8209123: [Macosx] Maximized frame is resizable on Mac but not on Windows and Ubuntu

Hi Krishna, Thanks for your review comments. Answers are updated inline to your queries. Please review the modified webrev: http://cr.openjdk.java.net/~mhalder/8209123/webrev.01/ Thanks, Manajit On 04/10/18 8:13 AM, Krishna Addepall

Re: RFR: 8211267 StackOverflowError happened by TextField.setFont(...)

Looks fine. On 02/10/2018 03:44, Ichiroh Takiguchi wrote: Hello Sergey. I appreciate your suggestion. Yeah, I should care about StateLock... So if xtext.setFont(font) is not called, also xtext.validate() is not called. Could you review fix and testcase again ? Bug:    https://bugs.openjdk.ja

Re: [12] JDK-8061359: [macosx] Checkbox toggles on Space press but does not spoken by Voice Over

Looks fine. On 01/10/2018 21:54, shashidhara.veerabhadra...@oracle.com wrote: Hi Sergey, Thanks for your review and here is the updated webrev: http://cr.openjdk.java.net/~sveerabhadra/8061359/webrev.01/ Thanks and regards, Shashi On 02/10/18 1:14 AM, Sergey Bylokhov wrote: Hi, Shashi. It

Re: [12] JDK-8061359: [macosx] Checkbox toggles on Space press but does not spoken by Voice Over

Thanks Sergey for your review. Thanks and regards, Shashi -Original Message- From: Sergey Bylokhov Sent: Friday, October 5, 2018 4:47 AM To: Shashidhara Veerabhadraiah ; awt-dev@openjdk.java.net; swing-...@openjdk.java.net Subject: Re: [12] JDK-8061359: [macosx] Checkbox toggles on Spa