Re: RFR[12]: 8211393 Memory leak issue on awt_InputMethod.c

2018-10-07 Thread Langer, Christoph
+1 > -Original Message- > From: i18n-dev On Behalf Of Ichiroh > Takiguchi > Sent: Dienstag, 2. Oktober 2018 18:30 > To: awt-dev@openjdk.java.net; i18n-...@openjdk.java.net > Subject: RFR[12]: 8211393 Memory leak issue on > awt_InputMethod.c > > Hello. > Could you review memory leak fix

Re: [12] Review Request: 8210231 Robot.delay() catches InterruptedException and prints stacktrace to stderr.

2018-10-07 Thread Krishna Addepalli
+1 Thanks, Krishna -Original Message- From: Sergey Bylokhov Sent: Monday, October 8, 2018 10:26 AM To: awt-dev@openjdk.java.net Subject: [12] Review Request: 8210231 Robot.delay() catches InterruptedException and prints stacktrace to stderr. Hello. Please review the fix for jdk12. Bu

Re: [12] Review request for JDK-8209123: [Macosx] Maximized frame is resizable on Mac but not on Windows and Ubuntu

2018-10-07 Thread Krishna Addepalli
Looks fine.   Krishna   From: Manajit Halder Sent: Thursday, October 4, 2018 6:01 PM To: Krishna Addepalli ; awt-dev@openjdk.java.net Subject: Re: [12] Review request for JDK-8209123: [Macosx] Maximized frame is resizable on Mac but not on Windows and Ubuntu   Hi Krishna, Thanks for your

[12] Review Request: 8210231 Robot.delay() catches InterruptedException and prints stacktrace to stderr.

2018-10-07 Thread Sergey Bylokhov
Hello. Please review the fix for jdk12. Bug: https://bugs.openjdk.java.net/browse/JDK-8210231 Webrev: http://cr.openjdk.java.net/~serb/8210231/webrev.00 The Robot.delay() is a simple wrapper on top of Thread.sleep(), which ignores the InterruptedException. But in case of InterruptedException it

RFR: 8211826 getGTKIcon with Unicode chars got StringIndexOutOfBoundsException

2018-10-07 Thread Ichiroh Takiguchi
Hello. Could you review the fix ? Bug:https://bugs.openjdk.java.net/browse/JDK-8211826 Change: https://cr.openjdk.java.net/~itakiguchi/8211826/webrev.00/ Thanks, Ichiroh Takiguchi IBM Japan, Ltd. On 2018-06-19 21:33, Ichiroh Takiguchi wrote: Hello, IBM would like to contribute a patch to

RFR: 8211810 X11 Time stamp data should be unsigned

2018-10-07 Thread Ichiroh Takiguchi
Hello. (Sorry, I put wrong bug id, please ignore previous mail) Could you review the fix ? Bug:https://bugs.openjdk.java.net/browse/JDK-8211810 Change: https://cr.openjdk.java.net/~itakiguchi/8211810/webrev.00/ Thanks, Ichiroh Takiguchi IBM Japan, Ltd. On 2018-10-08 11:20, Ichiroh Takiguchi

Re: Proposal: X11 Time stamp data should be unsigned

2018-10-07 Thread Ichiroh Takiguchi
Hello. Could you review the fix ? Bug:https://bugs.openjdk.java.net/browse/JDK-8211826 Change: https://cr.openjdk.java.net/~itakiguchi/8211826/webrev.00/ Thanks, Ichiroh Takiguchi IBM Japan, Ltd. On 2018-06-19 22:22, Ichiroh Takiguchi wrote: Hello, IBM would like to contribute a patch to O

[12] Review Request: 8211822 and 8202886

2018-10-07 Thread Sergey Bylokhov
Hello. Please review the fix for jdk12. Bug: Some tests fail after JDK-8210039 https://bugs.openjdk.java.net/browse/JDK-8211822 Bug: [macos] Test java/awt/MenuBar/8007006/bug8007006.java fails on MacOS https://bugs.openjdk.java.net/browse/JDK-8202886 Webrev: http://cr.openjdk.java.net/~